From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arc: Move dram_init out of arch code, into board code
Date: Thu, 15 Jun 2017 19:21:07 +0000 [thread overview]
Message-ID: <1497554466.2945.27.camel@synopsys.com> (raw)
In-Reply-To: <016844bc-c826-d74f-9087-8b27d91b8cc5@adaptrum.com>
Hi Alexandru,
On Mon, 2017-06-05 at 13:00 -0700, Alexandru Gagniuc wrote:
> On 06/05/2017 12:22 PM, Alexey Brodkin wrote:
> >
> > Hi Alexandru,
> >
> > On Mon, 2017-06-05 at 10:49 -0700, Alexandru Gagniuc wrote:
> > >
> > > The following commit
> > > f1683aa board_f: Rename initdram() to dram_init()
> > > wrongly assumed that the lack of DRAM init is the property of the
> > > architecture. In fact, it is only the AXS10x boards that do not need a
> > > special raminit. Those assumptions are not true on the ARC SoC we're
> > > looking at.
> >
> > Actually there're more boards with ARC cores.
> > In particular nSIM for ARC700 and ARC HS38, as well as Abilis TB100.
>
> Oops. Missed those. I'll have an updated patch later in the week.
>
>
> >
> > So it might make sense to declare generic dram_init() in arch/arc/lib/cpu.c
> > as a weak function and add your own implementations as needed.
>
> I disagree. The few saved lines of code to properly link the correct
> function are not worth the lost days when figuring out why my xyz()
> function is not doing the right thing.
>
>
> >
> > BTW since commit 80e4bbfcd92d "travisci: Add support for ARC"
>
> I'll give that a try, thanks!
Any progress with that one?
Or I'm missing your respin(s)?
-Alexey
next prev parent reply other threads:[~2017-06-15 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 17:49 [U-Boot] [PATCH] arc: Move dram_init out of arch code, into board code Alexandru Gagniuc
2017-06-05 19:22 ` Alexey Brodkin
2017-06-05 20:00 ` Alexandru Gagniuc
2017-06-15 19:21 ` Alexey Brodkin [this message]
2017-06-15 20:39 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497554466.2945.27.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.