From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>, netdev@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC 3/3] networking: make skb_push & __skb_push return void pointers
Date: Fri, 16 Jun 2017 02:19:18 -0700 [thread overview]
Message-ID: <1497604758.10546.3.camel@perches.com> (raw)
In-Reply-To: <20170615221217.16510-4-johannes@sipsolutions.net>
On Fri, 2017-06-16 at 00:12 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
[]
> diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
[]
> @@ -2090,10 +2090,10 @@ static int pn533_fill_fragment_skbs(struct pn533 *dev, struct sk_buff *skb)
>
> /* MI + TG */
> if (frag_size == PN533_CMD_DATAFRAME_MAXLEN)
> - *skb_push(frag, sizeof(u8)) =
> - (PN533_CMD_MI_MASK | 1);
> - else
> - *skb_push(frag, sizeof(u8)) = 1; /* TG */
> + *(u8 *)skb_push(frag, sizeof(u8)) =
> + (PN533_CMD_MI_MASK | 1);
> + else
> + *(u8 *)skb_push(frag, sizeof(u8)) = 1; /* TG */
Can you check all the if/else uses.
This one is not formatted correctly.
I didn't look at any others.
next prev parent reply other threads:[~2017-06-16 9:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 22:12 [RFC 0/3] make skb accessors return void pointers Johannes Berg
2017-06-15 22:12 ` [RFC 1/3] networking: make skb_put & friends " Johannes Berg
2017-06-16 7:53 ` Bjørn Mork
2017-06-16 8:42 ` Johannes Berg
2017-06-16 10:39 ` Joe Perches
2017-06-16 11:03 ` Johannes Berg
2017-06-16 11:26 ` Joe Perches
2017-06-15 22:12 ` [RFC 2/3] networking: make skb_pull " Johannes Berg
2017-06-15 22:12 ` [RFC 3/3] networking: make skb_push & __skb_push " Johannes Berg
2017-06-16 9:19 ` Joe Perches [this message]
2017-06-16 9:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497604758.10546.3.camel@perches.com \
--to=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.