From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matthias Brugger <mbrugger@suse.com>,
gregkh@linuxfoundation.org, jslaby@suse.com
Cc: ed.blake@imgtec.com, vigneshr@ti.com,
alexander.sverdlin@nokia.com, yegorslists@googlemail.com,
dhowells@redhat.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: Delete dead code for CIR serial ports
Date: Fri, 16 Jun 2017 14:43:54 +0300 [thread overview]
Message-ID: <1497613434.22624.145.camel@linux.intel.com> (raw)
In-Reply-To: <20170615155449.28482-1-mbrugger@suse.com>
On Thu, 2017-06-15 at 17:54 +0200, Matthias Brugger wrote:
> Commit e4fda3a04275 ("serial: don't register CIR serial ports") adds a
> check for PORT_8250_CIR to serial8250_register_8250_port(). But the
> code
> isn't needed as the function never takes the branch when the port is
> CIR
> serial port.
> + if (serial8250_isa_config != NULL)
> + serial8250_isa_config(0, &uart->port,
> + &uart->capabilities);
Can't it be one line after all?
>
> + ret = uart_add_one_port(&serial8250_reg,
> + &uart->port);
Ditto.
> + if (ret == 0)
> + ret = uart->port.line;
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-06-16 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 15:54 [PATCH] serial: Delete dead code for CIR serial ports Matthias Brugger
2017-06-16 11:43 ` Andy Shevchenko [this message]
2017-06-16 15:13 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497613434.22624.145.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.sverdlin@nokia.com \
--cc=dhowells@redhat.com \
--cc=ed.blake@imgtec.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=vigneshr@ti.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.