Re: [RFC] networking: add and use skb_put_u8()

[Joe Perches <joe@perches.com>]

On Fri, 2017-06-16 at 12:22 +0200, Johannes Berg wrote:
> On Fri, 2017-06-16 at 12:16 +0200, Arend van Spriel wrote:
> > 
> > >      @@
> > >      expression SKB, C, S;
> > >      typedef u8;
> > >      identifier fn = {skb_put};
> > >      fresh identifier fn2 = fn ## "_u8";
> > >      @@
> > >      - *(u8 *)fn(SKB, S) = C;
> > >      + fn2(SKB, C);
> > > 
> > > Note that due to the "C", the spatch isn't perfect, it should
> > > have checked that C is 1, but there's also places that use a
> > 
> > Don't you mean "S" here?
> 
> Indeed, I mean S, will fix.

Perhaps

	skb_put_data(skb, &c, sizeof(c))

as that avoids api expansion.

Optimizing the indirections and the size in a macro front-end
in skb_put_data may be better as it's would be completely
consistent for all use styles.