From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37530 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbdFRBEx (ORCPT ); Sat, 17 Jun 2017 21:04:53 -0400 Subject: Patch "mfd: cpcap: Fix interrupt to use level interrupt" has been added to the 4.11-stable tree To: tony@atomide.com, ckeepax@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org, lee.jones@linaro.org Cc: , From: Date: Sun, 18 Jun 2017 09:03:39 +0800 Message-ID: <149774781966112@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled mfd: cpcap: Fix interrupt to use level interrupt to the 4.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mfd-cpcap-fix-interrupt-to-use-level-interrupt.patch and it can be found in the queue-4.11 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ac89473213c602b98172d92e40f5e78032b1aba0 Mon Sep 17 00:00:00 2001 From: Tony Lindgren Date: Mon, 3 Apr 2017 20:15:54 -0700 Subject: mfd: cpcap: Fix interrupt to use level interrupt From: Tony Lindgren commit ac89473213c602b98172d92e40f5e78032b1aba0 upstream. I made a mistake assuming the device tree configuration for interrupt triggering was somehow passed to the SPI device but it's not. In the Motorola Linux kernel tree CPCAP PMIC is configured as a rising edge triggered interrupt, but then then it's interrupt handler keeps looping until the GPIO line goes down. So the CPCAP interrupt is clearly a level interrupt and not an edge interrupt. Earlier when I tried to configure it as level interrupt using the device tree, I did not account that the triggering only gets passed to the SPI core and it also needs to be specified in the CPCAP driver when we do devm_regmap_add_irq_chip(). Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") Signed-off-by: Tony Lindgren Acked-by: Charles Keepax Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/mfd/motorola-cpcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mfd/motorola-cpcap.c +++ b/drivers/mfd/motorola-cpcap.c @@ -126,7 +126,7 @@ static int cpcap_init_irq_chip(struct cp ret = devm_regmap_add_irq_chip(&cpcap->spi->dev, cpcap->regmap, cpcap->spi->irq, - IRQF_TRIGGER_RISING | + irq_get_trigger_type(cpcap->spi->irq) | IRQF_SHARED, -1, chip, &cpcap->irqdata[irq_chip]); if (ret) { Patches currently in stable-queue which might be from tony@atomide.com are queue-4.11/mfd-cpcap-fix-bad-use-of-irq-sense-register.patch queue-4.11/mfd-omap-usb-tll-fix-inverted-bit-use-for-usb-tll-mode.patch queue-4.11/mfd-cpcap-fix-interrupt-to-use-level-interrupt.patch queue-4.11/mfd-cpcap-use-ack_invert-interrupts.patch