From: Joe Perches <joe@perches.com>
To: Govindarajulu Varadarajan <gvaradar@cisco.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, benve@cisco.com
Subject: Re: [PATCH net-next] enic: use kasprintf instead of snprintf
Date: Sun, 18 Jun 2017 22:59:12 -0700 [thread overview]
Message-ID: <1497851952.8495.42.camel@perches.com> (raw)
In-Reply-To: <alpine.LNX.2.20.1706182248450.15793@cae-iprp-alln-lb.cisco.com>
On Sun, 2017-06-18 at 22:55 -0700, Govindarajulu Varadarajan wrote:
> On Sun, 18 Jun 2017, Joe Perches wrote:
>
> > Perhaps it'd be better to use a style
> > with a variable length format precision
> >
> > ie:
> >
> > "%.*s-tx-%u", IFNAMSIZ - 4 - <something>, netdev-name, i)
> >
>
> This would truncate interface name. Why is this preferred to my patch?
no allocation required, simpler.
next prev parent reply other threads:[~2017-06-19 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 5:05 [PATCH net-next] enic: use kasprintf instead of snprintf Govindarajulu Varadarajan
2017-06-19 5:40 ` Joe Perches
2017-06-19 5:55 ` Govindarajulu Varadarajan
2017-06-19 5:59 ` Joe Perches [this message]
2017-06-19 14:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497851952.8495.42.camel@perches.com \
--to=joe@perches.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=gvaradar@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.