All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Munteanu <rombert@apache.org>
To: Michel Hermier <michel.hermier@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [RFC v2 PATCH] Fix modifier keys for Redragon Asura Keyboard
Date: Mon, 19 Jun 2017 10:33:17 +0300	[thread overview]
Message-ID: <1497857597.5395.2.camel@apache.org> (raw)
In-Reply-To: <CAAZ5spBy_wzOYgZ42nuet-vp_FR1UHxyzz1fj8qdMqd0-DYuig@mail.gmail.com>

Hi Michel,

On Fri, 2017-06-16 at 08:30 +0200, Michel Hermier wrote:
> Are you sure it is the correct way to do it? I mean I looked a little
> to
> the hid descriptor and it seemed to be correct, at least the part
> that
> describe key modifiers. So it smell more like a hid parser bug,
> forgetting
> to consume/declare one byte before the modifiers bits.
> 

I am not sure about the correctness of the approach, thus the RFC :-)

It was also quite easy for me to discover the behaviour when using a
new module, but with the existing code base I find it harder to
navigate.

Can you point me to where the hid codes are parsed? Is it
hidinput_setkeycode in hid-input.c?

Thanks,

Robert

      parent reply	other threads:[~2017-06-19  7:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 22:24 [RFC v2 PATCH] Fix modifier keys for Redragon Asura Keyboard Robert Munteanu
     [not found] ` <CAAZ5spAeoQ0sycktP7zpoTRMb42EGS2=8ZODzmNi3=80MB-CzA@mail.gmail.com>
     [not found]   ` <CAAZ5spAV3tKc-52W4snYq3XRsw9uZ-ikDvAss3dSEk9hnFTitQ@mail.gmail.com>
     [not found]     ` <CAAZ5spBy_wzOYgZ42nuet-vp_FR1UHxyzz1fj8qdMqd0-DYuig@mail.gmail.com>
2017-06-19  7:33       ` Robert Munteanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497857597.5395.2.camel@apache.org \
    --to=rombert@apache.org \
    --cc=linux-input@vger.kernel.org \
    --cc=michel.hermier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.