From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1497872109.5380.10.camel@nxp.com> Subject: Re: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare From: Leonard Crestez To: Oleksij Rempel CC: Andrew Morton , , Fabio Estevam , , Liam Girdwood , , , , Mark Brown , Mark Rutland , "Michael Turquette" , Rob Herring , Russell King , Shawn Guo , Stephen Boyd Date: Mon, 19 Jun 2017 14:35:09 +0300 In-Reply-To: <20170619050245.2632-4-o.rempel@pengutronix.de> References: <20170619050245.2632-1-o.rempel@pengutronix.de> <20170619050245.2632-4-o.rempel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Return-Path: leonard.crestez@nxp.com List-ID: On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel > --- >  kernel/reboot.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index bd30a973fe94..a6903bf772c7 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; >   */ >   >  void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL(pm_power_off_prepare); >   Could you register a reboot notifier in the pfuze driver instead? Right now the only user of pm_power_off_prepare is ACPI so this alternative seems less intrusive. -- Regards, Leonard From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonard.crestez@nxp.com (Leonard Crestez) Date: Mon, 19 Jun 2017 14:35:09 +0300 Subject: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare In-Reply-To: <20170619050245.2632-4-o.rempel@pengutronix.de> References: <20170619050245.2632-1-o.rempel@pengutronix.de> <20170619050245.2632-4-o.rempel@pengutronix.de> Message-ID: <1497872109.5380.10.camel@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel > --- > ?kernel/reboot.c | 1 + > ?1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index bd30a973fe94..a6903bf772c7 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; > ? */ > ? > ?void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL(pm_power_off_prepare); > ? Could you register a reboot notifier in the pfuze driver instead? Right now the only user of pm_power_off_prepare is ACPI so this alternative seems less intrusive. -- Regards, Leonard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonard Crestez Subject: Re: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare Date: Mon, 19 Jun 2017 14:35:09 +0300 Message-ID: <1497872109.5380.10.camel@nxp.com> References: <20170619050245.2632-1-o.rempel@pengutronix.de> <20170619050245.2632-4-o.rempel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170619050245.2632-4-o.rempel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oleksij Rempel Cc: Andrew Morton , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabio Estevam , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Liam Girdwood , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Mark Rutland , Michael Turquette , Rob Herring , Russell King , Shawn Guo , Stephen Boyd List-Id: devicetree@vger.kernel.org On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote: > Export pm_power_off_prepare. It is needed to implement power off on > Freescale/NXP iMX6 based boards with external power management > integrated circuit (PMIC). > > Signed-off-by: Oleksij Rempel > --- >  kernel/reboot.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/kernel/reboot.c b/kernel/reboot.c > index bd30a973fe94..a6903bf772c7 100644 > --- a/kernel/reboot.c > +++ b/kernel/reboot.c > @@ -49,6 +49,7 @@ int reboot_force; >   */ >   >  void (*pm_power_off_prepare)(void); > +EXPORT_SYMBOL(pm_power_off_prepare); >   Could you register a reboot notifier in the pfuze driver instead? Right now the only user of pm_power_off_prepare is ACPI so this alternative seems less intrusive. -- Regards, Leonard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html