From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"osandov@fb.com" <osandov@fb.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v4 12/12] blk-mq: Warn when attempting to run a hardware queue that is not mapped
Date: Mon, 19 Jun 2017 23:10:28 +0000 [thread overview]
Message-ID: <1497913827.2989.4.camel@wdc.com> (raw)
In-Reply-To: <f8454b86-b7d2-1f9c-69f6-0e191cea1bef@kernel.dk>
On Mon, 2017-06-19 at 17:06 -0600, Jens Axboe wrote:
> On 06/19/2017 04:08 PM, Bart Van Assche wrote:
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1140,8 +1140,9 @@ static int blk_mq_hctx_next_cpu(struct blk_mq_hw_=
ctx *hctx)
> > static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bo=
ol async,
> > unsigned long msecs)
> > {
> > - if (unlikely(blk_mq_hctx_stopped(hctx) ||
> > - !blk_mq_hw_queue_mapped(hctx)))
> > + WARN_ON_ONCE(!blk_mq_hw_queue_mapped(hctx));
> > +
>=20
> if (WARN_ON_ONCE(!blk_mq_hw_queue_mapped(hctx)))
> return;
Hello Jens,
Thanks for having reviewed this patch series. I will make the requested
changes, retest and repost this patch series.
Bart.=
next prev parent reply other threads:[~2017-06-19 23:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 22:07 [PATCH v4 00/12] More patches for kernel v4.13 Bart Van Assche
2017-06-19 22:07 ` [PATCH v4 01/12] blk-mq: Reduce blk_mq_hw_ctx size Bart Van Assche
2017-06-20 6:31 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 02/12] block: Make request operation type argument declarations consistent Bart Van Assche
2017-06-20 6:32 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 03/12] block: Introduce request_queue.initialize_rq_fn() Bart Van Assche
2017-06-19 22:22 ` Jens Axboe
2017-06-20 6:34 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 04/12] block: Make most scsi_req_init() calls implicit Bart Van Assche
2017-06-20 6:37 ` Hannes Reinecke
2017-06-20 17:39 ` Bart Van Assche
2017-06-19 22:07 ` [PATCH v4 05/12] block: Change argument type of scsi_req_init() Bart Van Assche
2017-06-20 6:38 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 06/12] blk-mq: Initialize .rq_flags in blk_mq_rq_ctx_init() Bart Van Assche
2017-06-20 6:39 ` Hannes Reinecke
2017-06-20 9:22 ` Christoph Hellwig
2017-06-19 22:07 ` [PATCH v4 07/12] block: Add a comment above queue_lockdep_assert_held() Bart Van Assche
2017-06-20 6:39 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 08/12] block: Check locking assumptions at runtime Bart Van Assche
2017-06-20 6:40 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 09/12] block: Document what queue type each function is intended for Bart Van Assche
2017-06-20 6:41 ` Hannes Reinecke
2017-06-19 22:07 ` [PATCH v4 10/12] blk-mq: Document locking assumptions Bart Van Assche
2017-06-20 6:42 ` Hannes Reinecke
2017-06-19 22:08 ` [PATCH v4 11/12] block: Constify disk_type Bart Van Assche
2017-06-20 6:43 ` Hannes Reinecke
2017-06-19 22:08 ` [PATCH v4 12/12] blk-mq: Warn when attempting to run a hardware queue that is not mapped Bart Van Assche
2017-06-19 23:06 ` Jens Axboe
2017-06-19 23:10 ` Bart Van Assche [this message]
2017-06-20 6:43 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497913827.2989.4.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.