From: Rik van Riel <riel@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 2/3] nohz: Move idle balancer registration to idle path
Date: Tue, 20 Jun 2017 13:39:08 -0400 [thread overview]
Message-ID: <1497980348.20270.104.camel@redhat.com> (raw)
In-Reply-To: <1497838322-10913-3-git-send-email-fweisbec@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Mon, 2017-06-19 at 04:12 +0200, Frederic Weisbecker wrote:
> The idle load balancing registration path assumes that we only stop
> the
> tick when the CPU is idle, ignoring the nohz full case. As a result,
> a
> nohz full CPU that is running a task may be chosen to perform idle
> load
> balancing.
>
> Lets make sure that only CPUs in dynticks idle mode can be picked as
> idle load balancers.
Woah. Dang.
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-06-20 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 2:11 [PATCH 0/3] sched: A few nohz_full improvements Frederic Weisbecker
2017-06-19 2:12 ` [PATCH 1/3] sched/loadavg: Generalize idle naming to nohz Frederic Weisbecker
2017-06-20 17:38 ` Rik van Riel
2017-06-22 11:10 ` [tip:sched/core] sched/loadavg: Generalize "_idle" naming to "_nohz" tip-bot for Frederic Weisbecker
2017-06-19 2:12 ` [PATCH 2/3] nohz: Move idle balancer registration to idle path Frederic Weisbecker
2017-06-20 17:39 ` Rik van Riel [this message]
2017-06-22 11:11 ` [tip:sched/core] nohz: Move idle balancer registration to the " tip-bot for Frederic Weisbecker
2017-06-19 2:12 ` [PATCH 3/3] sched: Spare idle load balancing on nohz_full CPUs Frederic Weisbecker
2017-06-20 17:42 ` Rik van Riel
2017-06-20 19:06 ` Mike Galbraith
2017-06-21 13:23 ` Frederic Weisbecker
2017-06-20 20:26 ` Frederic Weisbecker
2017-06-22 11:11 ` [tip:sched/core] sched/fair: " tip-bot for Frederic Weisbecker
2017-06-22 13:52 ` Frederic Weisbecker
2017-06-22 19:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497980348.20270.104.camel@redhat.com \
--to=riel@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.