From: make at marvell.com <make@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pinctrl: a3700: Fix the issue that gpio controller is registered with wrong node id
Date: Thu, 22 Jun 2017 14:38:20 +0800 [thread overview]
Message-ID: <1498113500-28246-3-git-send-email-make@marvell.com> (raw)
In-Reply-To: <1498113500-28246-1-git-send-email-make@marvell.com>
From: Ken Ma <make@marvell.com>
In armada_37xx_gpiochip_register, the return value of fdtdec_get_bool
should be true when gpio-controller is found; current codes makes a
wrong inverse return value judgement, this patch fixes it.
Signed-off-by: Ken Ma <make@marvell.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Stefan Roese <sr@denx.de>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Kostya Porotchkin <kostap@marvell.com>
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 2ac66ec..27165b0 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -539,7 +539,7 @@ static int armada_37xx_gpiochip_register(struct udevice *parent,
}
fdt_for_each_subnode(subnode, blob, node) {
- if (!fdtdec_get_bool(blob, subnode, "gpio-controller")) {
+ if (fdtdec_get_bool(blob, subnode, "gpio-controller")) {
ret = 0;
break;
}
--
1.9.1
next prev parent reply other threads:[~2017-06-22 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 6:38 [U-Boot] [PATCH 0/2] *** SUBJECT HERE *** make at marvell.com
2017-06-22 6:38 ` [U-Boot] [PATCH 1/2] pinctrl: a3700: Fix uart2 group selection register mask make at marvell.com
2017-06-22 6:38 ` make at marvell.com [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-22 9:13 [U-Boot] [PATCH 0/2] *** SUBJECT HERE *** make at marvell.com
2017-06-22 9:13 ` [U-Boot] [PATCH 2/2] pinctrl: a3700: Fix the issue that gpio controller is registered with wrong node id make at marvell.com
2017-06-22 9:20 ` Stefan Roese
2017-06-23 8:40 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498113500-28246-3-git-send-email-make@marvell.com \
--to=make@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.