All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liang Chen <liangchen.linux@gmail.com>
To: linux-bcache@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, colyli@suse.de,
	bcache@linux.ewheeler.net, Liang Chen <liangchen.linux@gmail.com>
Subject: [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS
Date: Fri, 23 Jun 2017 15:15:11 +0800	[thread overview]
Message-ID: <1498202111-30469-1-git-send-email-liangchen.linux@gmail.com> (raw)

The id passed to ida_simple_remove has to be the one originally
allocated with ida_simple_get, not the one after multipling by
BCACHE_MINORS.

Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
---
 drivers/md/bcache/super.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index e57353e..9f64477 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -734,7 +734,8 @@ static void bcache_device_free(struct bcache_device *d)
 	if (d->disk && d->disk->queue)
 		blk_cleanup_queue(d->disk->queue);
 	if (d->disk) {
-		ida_simple_remove(&bcache_minor, d->disk->first_minor);
+		ida_simple_remove(&bcache_minor,
+				d->disk->first_minor / BCACHE_MINORS);
 		put_disk(d->disk);
 	}
 
@@ -784,7 +785,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
 
 	if (!(d->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||
 	    !(d->disk = alloc_disk(BCACHE_MINORS))) {
-		ida_simple_remove(&bcache_minor, minor);
+		ida_simple_remove(&bcache_minor, minor / BCACHE_MINORS);
 		return -ENOMEM;
 	}
 
-- 
1.8.3.1

             reply	other threads:[~2017-06-23  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23  7:15 Liang Chen [this message]
2017-06-23  7:30 ` [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS Coly Li
2017-06-23 11:36   ` Liang Chen
     [not found] ` <OF8F24365F.31FA34A2-ON48258148.00287923-48258148.002900E3@zte.com.cn>
2017-06-23 11:39   ` Liang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498202111-30469-1-git-send-email-liangchen.linux@gmail.com \
    --to=liangchen.linux@gmail.com \
    --cc=bcache@linux.ewheeler.net \
    --cc=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.