All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: "André Draszik" <git@andred.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] selftest/archiver: add tests for recipe type filtering
Date: Fri, 23 Jun 2017 10:43:00 -0500	[thread overview]
Message-ID: <1498232580.31575.85.camel@linux.intel.com> (raw)
In-Reply-To: <1498230471.25895.24.camel@andred.net>

On Fri, 2017-06-23 at 16:07 +0100, André Draszik wrote:
> On Fri, 2017-06-23 at 10:15 -0500, Leonardo Sandoval wrote:
> > On Fri, 2017-06-23 at 15:59 +0100, André Draszik wrote:
> > > From: André Draszik <adraszik@tycoint.com>
> > > 
> > > The archiver used to be able to filter based on COPYLEFT_RECIPE_TYPES.
> > > 
> > > Unfortunately, this got broken with the fix for
> > >   https://bugzilla.yoctoproject.org/show_bug.cgi?id=6929
> > > in commit ae9102bda398 ("copyleft_filter.bbclass: Allow to filter on
> > > name")
> > > 
> > > Add two tests to prevent that from happening again.
> > > 
> > > Signed-off-by: André Draszik <adraszik@tycoint.com>
> > > ---
> > >  meta/lib/oeqa/selftest/cases/archiver.py | 78
> > > ++++++++++++++++++++++++++++++++
> > >  1 file changed, 78 insertions(+)
> > > 
> > > diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
> > > b/meta/lib/oeqa/selftest/cases/archiver.py
> > > index 70c7282f22..9f686debe6 100644
> > > --- a/meta/lib/oeqa/selftest/cases/archiver.py
> > > +++ b/meta/lib/oeqa/selftest/cases/archiver.py
> > > @@ -39,3 +39,81 @@ class Archiver(OESelftestTestCase):
> > >          # Check that exclude_recipe was excluded
> > >          excluded_present = len(glob.glob(src_path + '/%s-*' %
> > > exclude_recipe))
> > >          self.assertFalse(excluded_present, 'Recipe %s was not
> > > excluded.' % exclude_recipe)
> > > +
> > > +
> > > +    @testcase(2012)
> > 
> > I believe the testcase ID is related to testopia, not sure if you
> > consider this. Usually, the QA team is the one assigning these numbers.
> 
> No, I just picked the next available number :-)

so please send a v2 removing these. archive tests are welcome!

> 
> A.
> 




  reply	other threads:[~2017-06-23 15:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 14:59 [PATCH 1/3] selftest/archiver: add tests for recipe type filtering André Draszik
2017-06-23 14:59 ` [PATCH 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-23 14:59 ` [PATCH 3/3] copyleft_filter.bbclass: restore possiblity to filter on type André Draszik
2017-06-23 15:15 ` [PATCH 1/3] selftest/archiver: add tests for recipe type filtering Leonardo Sandoval
2017-06-23 15:07   ` André Draszik
2017-06-23 15:43     ` Leonardo Sandoval [this message]
2017-06-26  8:18 ` [PATCH v2 " André Draszik
2017-06-26  8:18   ` [PATCH v2 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-26  8:18   ` [PATCH v2 3/3] copyleft_filter.bbclass: restore possiblity to filter on type André Draszik
2017-06-26  8:31 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev3) Patchwork
2017-06-26  8:31 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev4) Patchwork
2017-06-26  8:36 ` [PATCH v3 1/3] selftest/archiver: add tests for recipe type filtering André Draszik
2017-06-26  8:36   ` [PATCH v3 2/3] selftest/archiver: only execute deploy_archives task André Draszik
2017-06-26  8:36   ` [PATCH v3 3/3] copyleft_filter.bbclass: restore possiblity to filter on type André Draszik
2017-06-26  9:01 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev6) Patchwork
2017-06-26  9:01 ` ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev7) Patchwork
2017-06-26 10:32   ` André Draszik
2017-06-26 14:10     ` Leonardo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498232580.31575.85.camel@linux.intel.com \
    --to=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.