From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v3] vsprintf: Add %p extension "%pOF" for device tree Date: Fri, 23 Jun 2017 10:38:08 -0700 Message-ID: <1498239488.24295.20.camel@perches.com> References: <20170622204445.14930-1-robh@kernel.org> <20170623173053.636-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170623173053.636-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Frank Rowand , Mark Rutland , Randy Dunlap , Grant Likely Cc: Pantelis Antoniou , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2017-06-23 at 12:30 -0500, Rob Herring wrote: > From: Pantelis Antoniou > > 90% of the usage of device node's full_name is printing it out in a > kernel message. However, storing the full path for every node is > wasteful and redundant. With a custom format specifier, we can generate > the full path at run-time and eventually remove the full path from every > node. > > For instance typical use is: > pr_info("Frobbing node %s\n", node->full_name); > > Which can be written now as: > pr_info("Frobbing node %pOF\n", node); > > '%pO' is the base specifier to represent kobjects with '%pOF' > representing struct device_node. Currently, struct device_node is the > only supported type of kobject. > > More fine-grained control of formatting includes printing the name, > flags, path-spec name and others, explained in the documentation entry. > > Originally written by Pantelis, but pretty much rewrote the core > function using existing string/number functions. The 2 passes were > unnecessary and have been removed. Also, updated the checkpatch.pl > check. The unittest code was written by Grant Likely. > > Signed-off-by: Pantelis Antoniou > Signed-off-by: Rob Herring > --- > v3: > - Fix missing documentation updates using '%pOF' as the device_node > specifier. > - Update the commit msg and documentation to clearly define '%pO' is the > base specifier for kobjects. > - Rework device_node_gen_full_name() to avoid creating an array of node > pointers on the stack. Thanks Rob. This all seems sensible to me now. If you want: Acked-by: Joe Perches cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704AbdFWRiO (ORCPT ); Fri, 23 Jun 2017 13:38:14 -0400 Received: from smtprelay0197.hostedemail.com ([216.40.44.197]:34857 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754209AbdFWRiM (ORCPT ); Fri, 23 Jun 2017 13:38:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:4362:5007:6119:7576:7875:7903:7974:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12679:12740:12760:12895:13069:13095:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433:21451:21627:30012:30029:30034:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crown35_4752a92838c26 X-Filterd-Recvd-Size: 2730 Message-ID: <1498239488.24295.20.camel@perches.com> Subject: Re: [PATCH v3] vsprintf: Add %p extension "%pOF" for device tree From: Joe Perches To: Rob Herring , Frank Rowand , Mark Rutland , Randy Dunlap , Grant Likely Cc: Pantelis Antoniou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 23 Jun 2017 10:38:08 -0700 In-Reply-To: <20170623173053.636-1-robh@kernel.org> References: <20170622204445.14930-1-robh@kernel.org> <20170623173053.636-1-robh@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-06-23 at 12:30 -0500, Rob Herring wrote: > From: Pantelis Antoniou > > 90% of the usage of device node's full_name is printing it out in a > kernel message. However, storing the full path for every node is > wasteful and redundant. With a custom format specifier, we can generate > the full path at run-time and eventually remove the full path from every > node. > > For instance typical use is: > pr_info("Frobbing node %s\n", node->full_name); > > Which can be written now as: > pr_info("Frobbing node %pOF\n", node); > > '%pO' is the base specifier to represent kobjects with '%pOF' > representing struct device_node. Currently, struct device_node is the > only supported type of kobject. > > More fine-grained control of formatting includes printing the name, > flags, path-spec name and others, explained in the documentation entry. > > Originally written by Pantelis, but pretty much rewrote the core > function using existing string/number functions. The 2 passes were > unnecessary and have been removed. Also, updated the checkpatch.pl > check. The unittest code was written by Grant Likely. > > Signed-off-by: Pantelis Antoniou > Signed-off-by: Rob Herring > --- > v3: > - Fix missing documentation updates using '%pOF' as the device_node > specifier. > - Update the commit msg and documentation to clearly define '%pO' is the > base specifier for kobjects. > - Rework device_node_gen_full_name() to avoid creating an array of node > pointers on the stack. Thanks Rob. This all seems sensible to me now. If you want: Acked-by: Joe Perches cheers, Joe