From: "Szwichtenberg, Radoslaw" <radoslaw.szwichtenberg@intel.com>
To: "Intel-gfx@lists.freedesktop.org"
<Intel-gfx@lists.freedesktop.org>,
"tursulin@ursulin.net" <tursulin@ursulin.net>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Subject: Re: [RFC i-g-t 1/4] igt: Remove default from the engine list
Date: Mon, 26 Jun 2017 09:15:30 +0000 [thread overview]
Message-ID: <1498468528.25430.14.camel@intel.com> (raw)
In-Reply-To: <168fcbf1-3fda-f341-9f18-37711c2c92cd@linux.intel.com>
On Fri, 2017-06-23 at 15:35 +0100, Tvrtko Ursulin wrote:
> On 23/06/2017 15:17, Szwichtenberg, Radoslaw wrote:
> > On Fri, 2017-06-23 at 12:31 +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > >
> > > Default is not an engine but an ABI alias for RCS. Remove it
> > > from the engine list to eliminate redundant subtests and test
> > > passes.
> >
> > Does it mean that we will have an ABI part that we don't test?
>
> Second patch adds the ABI testing to gem_exec_basic. Plus there is and
> odd test here and there which explicitly sends batches to
> I915_EXEC_DEFAULT. But to me just basic verification that the default
> works sounds enough.
Looks good to me.
-Radek
> Regards,
>
> Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-26 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 11:31 [RFC i-g-t 0/4] Redundant test pruning Tvrtko Ursulin
2017-06-23 11:31 ` [RFC i-g-t 1/4] igt: Remove default from the engine list Tvrtko Ursulin
2017-06-23 14:17 ` Szwichtenberg, Radoslaw
2017-06-23 14:35 ` Tvrtko Ursulin
2017-06-26 9:15 ` Szwichtenberg, Radoslaw [this message]
2017-07-06 13:33 ` [PATCH i-g-t v2 " Tvrtko Ursulin
2017-07-06 13:35 ` Chris Wilson
2017-06-23 11:31 ` [RFC i-g-t 2/4] gem_exec_basic: Exercise the default engine selection Tvrtko Ursulin
2017-06-23 11:31 ` [RFC i-g-t 3/4] gem_sync: Add all and store_all subtests Tvrtko Ursulin
2017-06-23 11:31 ` [RFC i-g-t 4/4] extended.testlist: Remove some test-subtest combinations Tvrtko Ursulin
2017-06-26 16:09 ` [RFC i-g-t 0/4] Redundant test pruning Daniel Vetter
2017-06-27 8:02 ` Tvrtko Ursulin
2017-06-27 9:14 ` Daniel Vetter
2017-06-27 11:46 ` Chris Wilson
2017-06-27 13:10 ` Daniel Vetter
2017-07-05 13:30 ` Tvrtko Ursulin
2017-07-06 9:28 ` Daniel Vetter
2017-07-06 11:31 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498468528.25430.14.camel@intel.com \
--to=radoslaw.szwichtenberg@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.