All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
	Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org,
	Andrei Otcheretianski <andrei.otcheretianski@intel.com>,
	Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH] nl80211: Don't verify owner_nlportid on NAN commands
Date: Mon, 26 Jun 2017 12:58:42 +0200	[thread overview]
Message-ID: <1498474722.3318.2.camel@sipsolutions.net> (raw)
In-Reply-To: <5680f862-2025-0ff0-59a2-ae50e32cee76@broadcom.com> (sfid-20170623_230337_027084_2D56F2D7)

On Fri, 2017-06-23 at 23:03 +0200, Arend van Spriel wrote:
> 
> Also is this not a more fundamental flaw in netlink socket behavior.
> Should there be some priority imposed on command responses over event
> messages. Just seems like this patch is a workaround.

In a way, but it's not that easy. ACK messages are really just that,
messages, and having them bypass the queue might not be reasonable for
the use case, having them be queued unconditionally would open an
avenue for memory consumption attacks (send lots of dummy commands and
let the ACKs accumulate), and deleting already "delivered" message
could, I think, break semantics because I think delivery can be checked
by the sender?

Either way, I don't really see a good way to solve this problem in
netlink.

johannes

  reply	other threads:[~2017-06-26 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23  9:26 [PATCH] nl80211: Don't verify owner_nlportid on NAN commands Luca Coelho
2017-06-23 21:03 ` Arend van Spriel
2017-06-26 10:58   ` Johannes Berg [this message]
2017-06-26 11:22   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498474722.3318.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=andrei.otcheretianski@intel.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.