diff for duplicates of <1498494334.28955.58.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 13e01a0..4b84bf5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,37 +1,37 @@ Hi Rob, -On Mon, 2017-06-26@10:51 -0500, Rob Herring wrote: +On Mon, 2017-06-26 at 10:51 -0500, Rob Herring wrote: > On Mon, Jun 26, 2017 at 10:11 AM, Eugeniy Paltsev > <Eugeniy.Paltsev@synopsys.com> wrote: > > -> > From: Alexey Brodkin <abrodkin at synopsys.com> +> > From: Alexey Brodkin <abrodkin@synopsys.com> > > [snip] > > + -> > +???????chosen { -> > +???????????????bootargs = "earlycon=uart8250,mmio32,0xf0005000,115200n8 console=ttyS0,115200n8 debug print-fatal-signals=1"; +> > + chosen { +> > + bootargs = "earlycon=uart8250,mmio32,0xf0005000,115200n8 console=ttyS0,115200n8 debug print-fatal-signals=1"; > > Use stdout-path for the console. Really, the bootargs should be blank > and populated by the bootloader especially debug options. Agree but in case of devboards we quite often disable bootloader and -load Linux image in memory via JTAG. So in that case bootargs make perfect sense IMHO.? +load Linux image in memory via JTAG. So in that case bootargs make perfect sense IMHO. > > -> > +???????}; +> > + }; > > + -> > +???????cpu { +> > + cpu { > > 'cpu' is for cpu nodes, so need something different. Agree. > > -> > +???????????????compatible = "simple-bus"; -> > +???????????????#address-cells = <1>; -> > +???????????????#size-cells = <1>; +> > + compatible = "simple-bus"; +> > + #address-cells = <1>; +> > + #size-cells = <1>; > > There are no reg properties, so these aren't needed. This doesn't look > like a simple-bus either. @@ -41,21 +41,21 @@ Agree. Looks like that. Thanks. > > -> > +???????????????interrupt-parent = <&core_intc>; +> > + interrupt-parent = <&core_intc>; > > + -> > +???????????????core_clk: core_clk { +> > + core_clk: core_clk { > > core-clk { Ok. > > -> > +???????????????????????#clock-cells = <0>; -> > +???????????????????????compatible = "fixed-clock"; -> > +???????????????????????clock-frequency = <1000000000>; -> > +???????????????}; +> > + #clock-cells = <0>; +> > + compatible = "fixed-clock"; +> > + clock-frequency = <1000000000>; +> > + }; > > + -> > +???????????????core_intc: archs-intc at cpu { +> > + core_intc: archs-intc@cpu { > > cpu is not a valid unit-address. How are these interrupt controllers addressed? @@ -63,104 +63,104 @@ We have per-core INTC so each core communicates to its own INTC and there's no w for any core to talk with INTC of another core. But then we have the next level INTC which is IDU (Interrupt Distribution Unit) -which dispatches "common" IRQs to different upstream per-core INTC, see below its node.? +which dispatches "common" IRQs to different upstream per-core INTC, see below its node. > > -> > +???????????????????????compatible = "snps,archs-intc"; -> > +???????????????????????interrupt-controller; -> > +???????????????????????#interrupt-cells = <1>; -> > +???????????????}; +> > + compatible = "snps,archs-intc"; +> > + interrupt-controller; +> > + #interrupt-cells = <1>; +> > + }; > > + -> > +???????????????idu_intc: idu-interrupt-controller { -> > +???????????????????????compatible = "snps,archs-idu-intc"; -> > +???????????????????????interrupt-controller; -> > +???????????????????????#interrupt-cells = <1>; -> > +???????????????}; +> > + idu_intc: idu-interrupt-controller { +> > + compatible = "snps,archs-idu-intc"; +> > + interrupt-controller; +> > + #interrupt-cells = <1>; +> > + }; > > + -> > +???????????????arcpct0: pct { -> > +???????????????????????compatible = "snps,archs-pct"; -> > +???????????????}; -> > +???????}; +> > + arcpct0: pct { +> > + compatible = "snps,archs-pct"; +> > + }; +> > + }; > > + -> > +???????soc { -> > +???????????????compatible = "simple-bus"; -> > +???????????????#address-cells = <1>; -> > +???????????????#size-cells = <1>; -> > +???????????????interrupt-parent = <&idu_intc>; +> > + soc { +> > + compatible = "simple-bus"; +> > + #address-cells = <1>; +> > + #size-cells = <1>; +> > + interrupt-parent = <&idu_intc>; > > + -> > +???????????????ranges = <0x00000000 0xf0000000 0x10000000>; +> > + ranges = <0x00000000 0xf0000000 0x10000000>; > > + -> > +???????????????uart: dw-apb-uart at 5000 { +> > + uart: dw-apb-uart@5000 { > -> serial at ... +> serial@... Yep. > > -> > +???????????????????????compatible = "snps,dw-apb-uart"; -> > +???????????????????????reg = <0x5000 0x100>; -> > +???????????????????????clock-frequency = <33330000>; -> > +???????????????????????interrupts = <6>; -> > +???????????????????????baud = <115200>; -> > +???????????????????????reg-shift = <2>; -> > +???????????????????????reg-io-width = <4>; -> > +???????????????}; +> > + compatible = "snps,dw-apb-uart"; +> > + reg = <0x5000 0x100>; +> > + clock-frequency = <33330000>; +> > + interrupts = <6>; +> > + baud = <115200>; +> > + reg-shift = <2>; +> > + reg-io-width = <4>; +> > + }; > > + -> > +???????????????gmacclk: gmacclk { -> > +???????????????????????compatible = "fixed-clock"; -> > +???????????????????????clock-frequency = <400000000>; -> > +???????????????????????#clock-cells = <0>; -> > +???????????????}; +> > + gmacclk: gmacclk { +> > + compatible = "fixed-clock"; +> > + clock-frequency = <400000000>; +> > + #clock-cells = <0>; +> > + }; > > + -> > +???????????????mmcclk_ciu: mmcclk_ciu { +> > + mmcclk_ciu: mmcclk_ciu { > > Don't use underscores in node names. Ok. > > -> > +???????????????????????compatible = "fixed-clock"; -> > +???????????????????????clock-frequency = <100000000>; -> > +???????????????????????#clock-cells = <0>; -> > +???????????????}; +> > + compatible = "fixed-clock"; +> > + clock-frequency = <100000000>; +> > + #clock-cells = <0>; +> > + }; > > + -> > +???????????????mmcclk_biu: mmcclk_biu { -> > +???????????????????????compatible = "fixed-clock"; -> > +???????????????????????clock-frequency = <400000000>; -> > +???????????????????????#clock-cells = <0>; -> > +???????????????}; +> > + mmcclk_biu: mmcclk_biu { +> > + compatible = "fixed-clock"; +> > + clock-frequency = <400000000>; +> > + #clock-cells = <0>; +> > + }; > > + -> > +???????????????ethernet at 8000 { -> > +???????????????????????#interrupt-cells = <1>; -> > +???????????????????????compatible = "snps,dwmac"; -> > +???????????????????????reg = <0x8000 0x2000>; -> > +???????????????????????interrupts = <10>; -> > +???????????????????????interrupt-names = "macirq"; -> > +???????????????????????phy-mode = "rgmii"; -> > +???????????????????????snps,pbl = <32>; -> > +???????????????????????clocks = <&gmacclk>; -> > +???????????????????????clock-names = "stmmaceth"; -> > +???????????????????????phy-handle = <&phy0>; +> > + ethernet@8000 { +> > + #interrupt-cells = <1>; +> > + compatible = "snps,dwmac"; +> > + reg = <0x8000 0x2000>; +> > + interrupts = <10>; +> > + interrupt-names = "macirq"; +> > + phy-mode = "rgmii"; +> > + snps,pbl = <32>; +> > + clocks = <&gmacclk>; +> > + clock-names = "stmmaceth"; +> > + phy-handle = <&phy0>; > > + -> > +???????????????????????mdio0 { +> > + mdio0 { > > mdio { > > > -> > +???????????????????????????????#address-cells = <1>; -> > +???????????????????????????????#size-cells = <0>; -> > +???????????????????????????????compatible = "snps,dwmac-mdio"; -> > +???????????????????????????????phy0: ethernet-phy at 0 { -> > +???????????????????????????????????????reg = <0>; -> > +???????????????????????????????????????ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; -> > +???????????????????????????????????????ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; -> > +???????????????????????????????????????ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; -> > +???????????????????????????????}; -> > +???????????????????????}; -> > +???????????????}; +> > + #address-cells = <1>; +> > + #size-cells = <0>; +> > + compatible = "snps,dwmac-mdio"; +> > + phy0: ethernet-phy@0 { +> > + reg = <0>; +> > + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; +> > + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; +> > + ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; +> > + }; +> > + }; +> > + }; > > + -> > +???????????????ohci at 60000 { -> > +???????????????????????compatible = "generic-ohci"; +> > + ohci@60000 { +> > + compatible = "generic-ohci"; > > This should have an SoC specific compatible. @@ -168,46 +168,46 @@ But why? We don't have any SoC-specific extensions. This essentially applies to EHCI as well. > > -> > +???????????????????????reg = <0x60000 0x100>; -> > +???????????????????????interrupts = <15>; -> > +???????????????}; +> > + reg = <0x60000 0x100>; +> > + interrupts = <15>; +> > + }; > > + -> > +???????????????ehci at 40000 { -> > +???????????????????????compatible = "generic-ehci"; +> > + ehci@40000 { +> > + compatible = "generic-ehci"; > > This should have an SoC specific compatible. > > > -> > +???????????????????????reg = <0x40000 0x100>; -> > +???????????????????????interrupts = <15>; -> > +???????????????}; +> > + reg = <0x40000 0x100>; +> > + interrupts = <15>; +> > + }; > > + -> > +???????????????mmc at a000 { -> > +???????????????????????compatible = "altr,socfpga-dw-mshc"; -> > +???????????????????????reg = <0xa000 0x400>; -> > +???????????????????????num-slots = <1>; -> > +???????????????????????fifo-depth = <16>; -> > +???????????????????????card-detect-delay = <200>; -> > +???????????????????????clocks = <&mmcclk_biu>, <&mmcclk_ciu>; -> > +???????????????????????clock-names = "biu", "ciu"; -> > +???????????????????????interrupts = <12>; -> > +???????????????????????bus-width = <4>; -> > +???????????????}; -> > +???????}; +> > + mmc@a000 { +> > + compatible = "altr,socfpga-dw-mshc"; +> > + reg = <0xa000 0x400>; +> > + num-slots = <1>; +> > + fifo-depth = <16>; +> > + card-detect-delay = <200>; +> > + clocks = <&mmcclk_biu>, <&mmcclk_ciu>; +> > + clock-names = "biu", "ciu"; +> > + interrupts = <12>; +> > + bus-width = <4>; +> > + }; +> > + }; > > + -> > +???????memory { +> > + memory { > -> memory at 80000000 +> memory@80000000 Ok. > > > -> > +???????????????#address-cells = <1>; -> > +???????????????#size-cells = <1>; -> > +???????????????device_type = "memory"; -> > +???????????????reg = <0x80000000 0x40000000>;??/* 1 GiB */ -> > +???????}; +> > + #address-cells = <1>; +> > + #size-cells = <1>; +> > + device_type = "memory"; +> > + reg = <0x80000000 0x40000000>; /* 1 GiB */ +> > + }; > > +}; > > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig > > new file mode 100644 @@ -295,14 +295,14 @@ Ok. > > --- a/arch/arc/kernel/devtree.c > > +++ b/arch/arc/kernel/devtree.c > > @@ -29,8 +29,9 @@ static void __init arc_set_early_base_baud(unsigned long dt_root) -> > ?{ -> > ????????if (of_flat_dt_is_compatible(dt_root, "abilis,arc-tb10x")) -> > ????????????????arc_base_baud = 166666666;??????/* Fixed 166.6MHz clk (TB10x) */ -> > -???????else if (of_flat_dt_is_compatible(dt_root, "snps,arc-sdp")) -> > -???????????????arc_base_baud = 33333333;???????/* Fixed 33MHz clk (AXS10x) */ -> > +???????else if (of_flat_dt_is_compatible(dt_root, "snps,arc-sdp") || -> > +????????????????of_flat_dt_is_compatible(dt_root, "snps,hsdk")) -> > +???????????????arc_base_baud = 33333333;???????/* Fixed 33MHz clk (AXS10x & HSDK) */ +> > { +> > if (of_flat_dt_is_compatible(dt_root, "abilis,arc-tb10x")) +> > arc_base_baud = 166666666; /* Fixed 166.6MHz clk (TB10x) */ +> > - else if (of_flat_dt_is_compatible(dt_root, "snps,arc-sdp")) +> > - arc_base_baud = 33333333; /* Fixed 33MHz clk (AXS10x) */ +> > + else if (of_flat_dt_is_compatible(dt_root, "snps,arc-sdp") || +> > + of_flat_dt_is_compatible(dt_root, "snps,hsdk")) +> > + arc_base_baud = 33333333; /* Fixed 33MHz clk (AXS10x & HSDK) */ > > You should get this info from DT. You don't need to address that now though. @@ -312,13 +312,13 @@ unflattened. The only thing I may think of early platform code that extracts this value from .dtb image but: -?1) I'm not sure it is more elegant -?2) Still it will be a bit too late - now we start printing very-very early. + 1) I'm not sure it is more elegant + 2) Still it will be a bit too late - now we start printing very-very early. > > -> > ????????else if (of_flat_dt_is_compatible(dt_root, "ezchip,arc-nps")) -> > ????????????????arc_base_baud = 800000000;??????/* Fixed 800MHz clk (NPS) */ -> > ????????else +> > else if (of_flat_dt_is_compatible(dt_root, "ezchip,arc-nps")) +> > arc_base_baud = 800000000; /* Fixed 800MHz clk (NPS) */ +> > else > > diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig > > new file mode 100644 > > index 0000000..29dffed @@ -334,7 +334,7 @@ image but: > > +# > > + > > +menuconfig ARC_PLAT_HSDK -> > +???????bool "ARC HS Development Kit board" +> > + bool "ARC HS Development Kit board" > > Per board config options don't scale and shouldn't be necessary with DT... diff --git a/a/content_digest b/N1/content_digest index d412e27..db6c2e7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,46 +1,52 @@ "ref\020170626151118.19507-1-Eugeniy.Paltsev@synopsys.com\0" "ref\020170626151118.19507-4-Eugeniy.Paltsev@synopsys.com\0" "ref\0CAL_JsqJBPL+AuYNP=JgXWOGNFxdenKY4Rt3_f6tG6MYDLncRNg@mail.gmail.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board\0" "Date\0Mon, 26 Jun 2017 16:25:35 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0robh+dt@kernel.org <robh+dt@kernel.org>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + Vineet.Gupta1@synopsys.com <Vineet.Gupta1@synopsys.com> + Alexey.Brodkin@synopsys.com <Alexey.Brodkin@synopsys.com> + Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + " devicetree@vger.kernel.org <devicetree@vger.kernel.org>\0" "\00:1\0" "b\0" "Hi Rob,\n" "\n" - "On Mon, 2017-06-26@10:51 -0500, Rob Herring wrote:\n" + "On Mon, 2017-06-26 at 10:51 -0500, Rob Herring wrote:\n" "> On Mon, Jun 26, 2017 at 10:11 AM, Eugeniy Paltsev\n" "> <Eugeniy.Paltsev@synopsys.com> wrote:\n" "> > \n" - "> > From: Alexey Brodkin <abrodkin at synopsys.com>\n" + "> > From: Alexey Brodkin <abrodkin@synopsys.com>\n" "> > \n" "\n" "[snip]\n" "\n" "> > +\n" - "> > +???????chosen {\n" - "> > +???????????????bootargs = \"earlycon=uart8250,mmio32,0xf0005000,115200n8 console=ttyS0,115200n8 debug print-fatal-signals=1\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240chosen {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240bootargs = \"earlycon=uart8250,mmio32,0xf0005000,115200n8 console=ttyS0,115200n8 debug print-fatal-signals=1\";\n" "> \n" "> Use stdout-path for the console. Really, the bootargs should be blank\n" "> and populated by the bootloader especially debug options.\n" "\n" "Agree but in case of devboards we quite often disable bootloader and\n" - "load Linux image in memory via JTAG. So in that case bootargs make perfect sense IMHO.?\n" + "load Linux image in memory via JTAG. So in that case bootargs make perfect sense IMHO.\302\240\n" "\n" "> > \n" - "> > +???????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????cpu {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240cpu {\n" "> \n" "> 'cpu' is for cpu nodes, so need something different.\n" "\n" "Agree.\n" "\n" "> > \n" - "> > +???????????????compatible = \"simple-bus\";\n" - "> > +???????????????#address-cells = <1>;\n" - "> > +???????????????#size-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"simple-bus\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#address-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#size-cells = <1>;\n" "> \n" "> There are no reg properties, so these aren't needed. This doesn't look\n" "> like a simple-bus either.\n" @@ -50,21 +56,21 @@ "Looks like that. Thanks.\n" "\n" "> > \n" - "> > +???????????????interrupt-parent = <&core_intc>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupt-parent = <&core_intc>;\n" "> > +\n" - "> > +???????????????core_clk: core_clk {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240core_clk: core_clk {\n" "> \n" "> core-clk {\n" "\n" "Ok.\n" "\n" "> > \n" - "> > +???????????????????????#clock-cells = <0>;\n" - "> > +???????????????????????compatible = \"fixed-clock\";\n" - "> > +???????????????????????clock-frequency = <1000000000>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#clock-cells = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"fixed-clock\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-frequency = <1000000000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????core_intc: archs-intc at cpu {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240core_intc: archs-intc@cpu {\n" "> \n" "> cpu is not a valid unit-address. How are these interrupt controllers addressed?\n" "\n" @@ -72,104 +78,104 @@ "for any core to talk with INTC of another core.\n" "\n" "But then we have the next level INTC which is IDU (Interrupt Distribution Unit)\n" - "which dispatches \"common\" IRQs to different upstream per-core INTC, see below its node.?\n" + "which dispatches \"common\" IRQs to different upstream per-core INTC, see below its node.\302\240\n" "\n" "> > \n" - "> > +???????????????????????compatible = \"snps,archs-intc\";\n" - "> > +???????????????????????interrupt-controller;\n" - "> > +???????????????????????#interrupt-cells = <1>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,archs-intc\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupt-controller;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#interrupt-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????idu_intc: idu-interrupt-controller {\n" - "> > +???????????????????????compatible = \"snps,archs-idu-intc\";\n" - "> > +???????????????????????interrupt-controller;\n" - "> > +???????????????????????#interrupt-cells = <1>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240idu_intc: idu-interrupt-controller {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,archs-idu-intc\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupt-controller;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#interrupt-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????arcpct0: pct {\n" - "> > +???????????????????????compatible = \"snps,archs-pct\";\n" - "> > +???????????????};\n" - "> > +???????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240arcpct0: pct {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,archs-pct\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????soc {\n" - "> > +???????????????compatible = \"simple-bus\";\n" - "> > +???????????????#address-cells = <1>;\n" - "> > +???????????????#size-cells = <1>;\n" - "> > +???????????????interrupt-parent = <&idu_intc>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240soc {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"simple-bus\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#address-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#size-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupt-parent = <&idu_intc>;\n" "> > +\n" - "> > +???????????????ranges = <0x00000000 0xf0000000 0x10000000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ranges = <0x00000000 0xf0000000 0x10000000>;\n" "> > +\n" - "> > +???????????????uart: dw-apb-uart at 5000 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240uart: dw-apb-uart@5000 {\n" "> \n" - "> serial at ...\n" + "> serial@...\n" "\n" "Yep.\n" "\n" "> > \n" - "> > +???????????????????????compatible = \"snps,dw-apb-uart\";\n" - "> > +???????????????????????reg = <0x5000 0x100>;\n" - "> > +???????????????????????clock-frequency = <33330000>;\n" - "> > +???????????????????????interrupts = <6>;\n" - "> > +???????????????????????baud = <115200>;\n" - "> > +???????????????????????reg-shift = <2>;\n" - "> > +???????????????????????reg-io-width = <4>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,dw-apb-uart\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x5000 0x100>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-frequency = <33330000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupts = <6>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240baud = <115200>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg-shift = <2>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg-io-width = <4>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????gmacclk: gmacclk {\n" - "> > +???????????????????????compatible = \"fixed-clock\";\n" - "> > +???????????????????????clock-frequency = <400000000>;\n" - "> > +???????????????????????#clock-cells = <0>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240gmacclk: gmacclk {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"fixed-clock\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-frequency = <400000000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#clock-cells = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????mmcclk_ciu: mmcclk_ciu {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240mmcclk_ciu: mmcclk_ciu {\n" "> \n" "> Don't use underscores in node names.\n" "\n" "Ok.\n" "\n" "> > \n" - "> > +???????????????????????compatible = \"fixed-clock\";\n" - "> > +???????????????????????clock-frequency = <100000000>;\n" - "> > +???????????????????????#clock-cells = <0>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"fixed-clock\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-frequency = <100000000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#clock-cells = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????mmcclk_biu: mmcclk_biu {\n" - "> > +???????????????????????compatible = \"fixed-clock\";\n" - "> > +???????????????????????clock-frequency = <400000000>;\n" - "> > +???????????????????????#clock-cells = <0>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240mmcclk_biu: mmcclk_biu {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"fixed-clock\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-frequency = <400000000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#clock-cells = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????ethernet at 8000 {\n" - "> > +???????????????????????#interrupt-cells = <1>;\n" - "> > +???????????????????????compatible = \"snps,dwmac\";\n" - "> > +???????????????????????reg = <0x8000 0x2000>;\n" - "> > +???????????????????????interrupts = <10>;\n" - "> > +???????????????????????interrupt-names = \"macirq\";\n" - "> > +???????????????????????phy-mode = \"rgmii\";\n" - "> > +???????????????????????snps,pbl = <32>;\n" - "> > +???????????????????????clocks = <&gmacclk>;\n" - "> > +???????????????????????clock-names = \"stmmaceth\";\n" - "> > +???????????????????????phy-handle = <&phy0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ethernet@8000 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#interrupt-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,dwmac\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x8000 0x2000>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupts = <10>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupt-names = \"macirq\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240phy-mode = \"rgmii\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240snps,pbl = <32>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clocks = <&gmacclk>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-names = \"stmmaceth\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240phy-handle = <&phy0>;\n" "> > +\n" - "> > +???????????????????????mdio0 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240mdio0 {\n" "> \n" "> mdio {\n" "> \n" "> > \n" - "> > +???????????????????????????????#address-cells = <1>;\n" - "> > +???????????????????????????????#size-cells = <0>;\n" - "> > +???????????????????????????????compatible = \"snps,dwmac-mdio\";\n" - "> > +???????????????????????????????phy0: ethernet-phy at 0 {\n" - "> > +???????????????????????????????????????reg = <0>;\n" - "> > +???????????????????????????????????????ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;\n" - "> > +???????????????????????????????????????ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;\n" - "> > +???????????????????????????????????????ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;\n" - "> > +???????????????????????????????};\n" - "> > +???????????????????????};\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#address-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#size-cells = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"snps,dwmac-mdio\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240phy0: ethernet-phy@0 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????ohci at 60000 {\n" - "> > +???????????????????????compatible = \"generic-ohci\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ohci@60000 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"generic-ohci\";\n" "> \n" "> This should have an SoC specific compatible.\n" "\n" @@ -177,46 +183,46 @@ "This essentially applies to EHCI as well.\n" "\n" "> > \n" - "> > +???????????????????????reg = <0x60000 0x100>;\n" - "> > +???????????????????????interrupts = <15>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x60000 0x100>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupts = <15>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????ehci at 40000 {\n" - "> > +???????????????????????compatible = \"generic-ehci\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ehci@40000 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"generic-ehci\";\n" "> \n" "> This should have an SoC specific compatible.\n" "> \n" "> > \n" - "> > +???????????????????????reg = <0x40000 0x100>;\n" - "> > +???????????????????????interrupts = <15>;\n" - "> > +???????????????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x40000 0x100>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupts = <15>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????????????mmc at a000 {\n" - "> > +???????????????????????compatible = \"altr,socfpga-dw-mshc\";\n" - "> > +???????????????????????reg = <0xa000 0x400>;\n" - "> > +???????????????????????num-slots = <1>;\n" - "> > +???????????????????????fifo-depth = <16>;\n" - "> > +???????????????????????card-detect-delay = <200>;\n" - "> > +???????????????????????clocks = <&mmcclk_biu>, <&mmcclk_ciu>;\n" - "> > +???????????????????????clock-names = \"biu\", \"ciu\";\n" - "> > +???????????????????????interrupts = <12>;\n" - "> > +???????????????????????bus-width = <4>;\n" - "> > +???????????????};\n" - "> > +???????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240mmc@a000 {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible = \"altr,socfpga-dw-mshc\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0xa000 0x400>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240num-slots = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240fifo-depth = <16>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240card-detect-delay = <200>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clocks = <&mmcclk_biu>, <&mmcclk_ciu>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clock-names = \"biu\", \"ciu\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240interrupts = <12>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240bus-width = <4>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +\n" - "> > +???????memory {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240memory {\n" "> \n" - "> memory at 80000000\n" + "> memory@80000000\n" "\n" "Ok.\n" "\n" "> \n" "> > \n" - "> > +???????????????#address-cells = <1>;\n" - "> > +???????????????#size-cells = <1>;\n" - "> > +???????????????device_type = \"memory\";\n" - "> > +???????????????reg = <0x80000000 0x40000000>;??/* 1 GiB */\n" - "> > +???????};\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#address-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#size-cells = <1>;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_type = \"memory\";\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240reg = <0x80000000 0x40000000>;\302\240\302\240/* 1 GiB */\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240};\n" "> > +};\n" "> > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig\n" "> > new file mode 100644\n" @@ -304,14 +310,14 @@ "> > --- a/arch/arc/kernel/devtree.c\n" "> > +++ b/arch/arc/kernel/devtree.c\n" "> > @@ -29,8 +29,9 @@ static void __init arc_set_early_base_baud(unsigned long dt_root)\n" - "> > ?{\n" - "> > ????????if (of_flat_dt_is_compatible(dt_root, \"abilis,arc-tb10x\"))\n" - "> > ????????????????arc_base_baud = 166666666;??????/* Fixed 166.6MHz clk (TB10x) */\n" - "> > -???????else if (of_flat_dt_is_compatible(dt_root, \"snps,arc-sdp\"))\n" - "> > -???????????????arc_base_baud = 33333333;???????/* Fixed 33MHz clk (AXS10x) */\n" - "> > +???????else if (of_flat_dt_is_compatible(dt_root, \"snps,arc-sdp\") ||\n" - "> > +????????????????of_flat_dt_is_compatible(dt_root, \"snps,hsdk\"))\n" - "> > +???????????????arc_base_baud = 33333333;???????/* Fixed 33MHz clk (AXS10x & HSDK) */\n" + "> > \302\240{\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (of_flat_dt_is_compatible(dt_root, \"abilis,arc-tb10x\"))\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240arc_base_baud = 166666666;\302\240\302\240\302\240\302\240\302\240\302\240/* Fixed 166.6MHz clk (TB10x) */\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240else if (of_flat_dt_is_compatible(dt_root, \"snps,arc-sdp\"))\n" + "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240arc_base_baud = 33333333;\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* Fixed 33MHz clk (AXS10x) */\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240else if (of_flat_dt_is_compatible(dt_root, \"snps,arc-sdp\") ||\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240of_flat_dt_is_compatible(dt_root, \"snps,hsdk\"))\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240arc_base_baud = 33333333;\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* Fixed 33MHz clk (AXS10x & HSDK) */\n" "> \n" "> You should get this info from DT. You don't need to address that now though.\n" "\n" @@ -321,13 +327,13 @@ "\n" "The only thing I may think of early platform code that extracts this value from .dtb\n" "image but:\n" - "?1) I'm not sure it is more elegant\n" - "?2) Still it will be a bit too late - now we start printing very-very early.\n" + "\302\2401) I'm not sure it is more elegant\n" + "\302\2402) Still it will be a bit too late - now we start printing very-very early.\n" "\n" "> > \n" - "> > ????????else if (of_flat_dt_is_compatible(dt_root, \"ezchip,arc-nps\"))\n" - "> > ????????????????arc_base_baud = 800000000;??????/* Fixed 800MHz clk (NPS) */\n" - "> > ????????else\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240else if (of_flat_dt_is_compatible(dt_root, \"ezchip,arc-nps\"))\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240arc_base_baud = 800000000;\302\240\302\240\302\240\302\240\302\240\302\240/* Fixed 800MHz clk (NPS) */\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240else\n" "> > diff --git a/arch/arc/plat-hsdk/Kconfig b/arch/arc/plat-hsdk/Kconfig\n" "> > new file mode 100644\n" "> > index 0000000..29dffed\n" @@ -343,7 +349,7 @@ "> > +#\n" "> > +\n" "> > +menuconfig ARC_PLAT_HSDK\n" - "> > +???????bool \"ARC HS Development Kit board\"\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240bool \"ARC HS Development Kit board\"\n" "> \n" "> Per board config options don't scale and shouldn't be necessary with DT...\n" "\n" @@ -352,4 +358,4 @@ "\n" -Alexey -a7230fdfca2dfd07622288e8ae4f79089fb3f4cb868b97c3c4404569454bd5aa +f6bfe9dd438e738bd878b136875e7e5ce0b0db09faeb2caf9c7f3251472a49f3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.