Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2017-06-22 at 11:17 +0100, Luis Oliveira wrote:
> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
> - Slave functions added to core library file
> - Slave abort sources added to common source file
> - New driver: i2c-designware-slave added
> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>   when supported by the architecture.
> 
> All the SLAVE flow is added but it is not enabled via platform
> driver.

There are couple of nits, otherwise I'm okay with the patch.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> V11-v12
> - Changed ifdef condition in the Makefile fixed Kbuild error

+ rebased on top of latest i2c-next (drop applied patches effectively)

> +static int i2c_dw_irq_handler_slave(struct dw_i2c_dev *dev)
> +{
> 

> +	dev_dbg(dev->dev,

> +		"%#x STAUTS SLAVE_ACTTVITY=%#x : RAW_INTR_STAT=%#x"
> +		" : INTR_STAT=%#x\n",

Don't split string literals.

> +		enabled, slave_activity, raw_stat, stat);


> +					dev_vdbg(dev->dev, "Byte %X
> acked!",
> +						 val);

I'm not sure it's any helpful.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy