From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Phil Elwell" <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
Cc: Peter Hurley
<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Yegor Yefremov
<yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI
Date: Wed, 28 Jun 2017 15:01:33 +0300 [thread overview]
Message-ID: <1498651293.22624.219.camel@linux.intel.com> (raw)
In-Reply-To: <20170628105744.42bchlftl6khvsxd-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, 2017-06-28 at 12:57 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote:
> > Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> > Acked-by: Eric Anholt <eric@anholt.net>
> > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > Changes in v2:
> > Add review tags.
>
> nitpick: The order of lines in the Sob area matter and you should add
> your Sob at the end. So as it was you adding the ack by Eric and Andy,
> it should look as follows:
>
> Acked-by: Eric Anholt <eric@anholt.net>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>
> . Note that this comment is very picky, quite some people don't get it
> right and I never saw a maintainer refuse a patch because of this. So
> this probably doesn't warrant a v3 :-)
Yeah, it's easily learned when one is using
% git commit -s [--amend]
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
linux-rpi-kernel mailing list
linux-rpi-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
prev parent reply other threads:[~2017-06-28 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 9:41 [PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI Phil Elwell
[not found] ` <1498642885-8063-1-git-send-email-phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-28 10:57 ` Uwe Kleine-König
[not found] ` <20170628105744.42bchlftl6khvsxd-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-28 11:52 ` Phil Elwell
[not found] ` <95a13280-e9f6-50f5-bb0c-8bcdefd0bf12-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2017-06-28 12:00 ` Andy Shevchenko
2017-06-28 13:04 ` Uwe Kleine-König
2017-06-28 12:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498651293.22624.219.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
--cc=phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.