Re: [PATCH v2] nl80211: Don't verify owner_nlportid on NAN commands

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2017-06-26 at 19:52 +0300, Luca Coelho wrote:
> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
> 
> If NAN interface is created with NL80211_ATTR_SOCKET_OWNER, the
> socket
> that is used to create the interface is used for all NAN operations
> and
> reporting NAN events.
> However, it turns out that sending commands and receiving events on
> the same socket is not possible in a completely race-free way:
> If the socket buffer is overflowed by the events, the command
> response
> will not be sent. In that case the caller will block forever on recv.
> Using non-blocking socket for commands is more complicated and still
> the command response or ack may not be received.
> So, keep unicasting NAN events to the interface creator, but allow
> using a different socket for commands.
> 
> Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com
> >
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> 

Agree with Andrei regarding the documentation.

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

johannes