From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Scott Jiang <scott.jiang.linux@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Andy Walls <awalls@md.metrocast.net>,
Prabhakar Lad <prabhakar.csengg@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomasz Stanislawski <t.stanislaws@samsung.com>,
Alexey Klimov <klimov.linux@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Brian Johnson <brijohn@gmail.com>, Mike Isely <isely@pobox.com>,
Ezequiel Garcia <elezegarcia@gmail.com>,
Huang Shijie <shijie8@gmail.com>,
Ismael Luceno <ismael.luceno@corp.bluecherry.net>,
Takashi Iwai <tiwai@suse.de>,
Ondrej Zary <linux@rainbow-software.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [REVIEW PATCH 2/5] v4l2: add const to argument of write-only s_tuner ioctl.
Date: Fri, 15 Mar 2013 13:12:10 +0100 [thread overview]
Message-ID: <1498993.HJaNmHCFIv@avalon> (raw)
In-Reply-To: <097e3e28dc8fbe8105fa3b2a489e18a5c5eca7bb.1363342714.git.hans.verkuil@cisco.com>
Hi Hans,
Thanks for the patch.
On Friday 15 March 2013 11:27:22 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This ioctl is defined as IOW, so pass the argument as const.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-03-15 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 10:27 [REVIEW PATCH 0/5] v4l2: constify _IOW ioctls Hans Verkuil
2013-03-15 10:27 ` [REVIEW PATCH 1/5] v4l2: add const to argument of write-only s_frequency ioctl Hans Verkuil
2013-03-15 10:27 ` [REVIEW PATCH 2/5] v4l2: add const to argument of write-only s_tuner ioctl Hans Verkuil
2013-03-15 12:12 ` Laurent Pinchart [this message]
2013-03-16 12:18 ` Alexey Klimov
2013-03-15 10:27 ` [REVIEW PATCH 3/5] v4l2: pass std by value to the write-only s_std ioctl Hans Verkuil
2013-03-15 12:17 ` Laurent Pinchart
2013-03-15 13:38 ` Jonathan Corbet
2013-03-15 13:58 ` Mauro Carvalho Chehab
2013-03-15 14:14 ` Hans Verkuil
2013-03-16 6:46 ` Guennadi Liakhovetski
2013-03-16 7:26 ` Prabhakar Lad
2013-03-15 10:27 ` [REVIEW PATCH 4/5] v4l2: add const to argument of write-only s_register ioctl Hans Verkuil
2013-03-15 12:22 ` Laurent Pinchart
2013-03-16 6:50 ` Guennadi Liakhovetski
2013-03-16 7:43 ` Prabhakar Lad
2013-03-15 10:27 ` [REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code Hans Verkuil
2013-03-15 12:25 ` Laurent Pinchart
2013-03-18 13:52 ` Hans Verkuil
2013-03-15 12:08 ` [REVIEW PATCH 1/5] v4l2: add const to argument of write-only s_frequency ioctl Laurent Pinchart
2013-03-15 12:18 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498993.HJaNmHCFIv@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=awalls@md.metrocast.net \
--cc=brijohn@gmail.com \
--cc=corbet@lwn.net \
--cc=elezegarcia@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=isely@pobox.com \
--cc=ismael.luceno@corp.bluecherry.net \
--cc=klimov.linux@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=mchehab@redhat.com \
--cc=prabhakar.csengg@gmail.com \
--cc=scott.jiang.linux@gmail.com \
--cc=shijie8@gmail.com \
--cc=t.stanislaws@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.