From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers Date: Mon, 03 Jul 2017 10:55:03 +0200 Message-ID: <1499072103.771.7.camel@redhat.com> References: <1499032363-8290-1-git-send-email-mark.cave-ayland@ilande.co.uk> <20170703081116.rub4ty5ewpi5af3o@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 256CF6E1F5 for ; Mon, 3 Jul 2017 08:55:05 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Cave-Ayland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org ICBIaSwKCj4gSG9wZWZ1bGx5IEdlcmQgaGFzIGV4cGVyaWVuY2UgdXNpbmcgYm9jaHNfZHJtIHdp dGggb3RoZXIgbm9uLXg4Ngo+IHN5c3RlbXMKPiBhbmQgY2FuIGNvbW1lbnQgZnVydGhlci4KCkp1 c3QgcHVzaGVkIHRvIGRybS1taXNjLW5leHQsIGZpeCBpcyBjb3JyZWN0LiAgYm9jaHMgdmlkZW8g bWVtb3J5IGlzIGEKcGNpIGJhciwgYW5kIHRoZSBmcmFtZWJ1ZmZlciBpcyBzdG9yZWQgdGhlcmUu CgpVc2luZyBzeXMgaW5zdGVhZCBvZiBjZmIgaXMgcHJvYmFibHkgYSBsZWZ0b3ZlciBmcm9tIGNp cnJ1cywgd2hlcmUgdGhlCmZyYW1lYnVmZmVyIGFjdHVhbGx5IGluIGEgc2hhZG93IGNvcHkgaW4g c3lzdGVtIHJhbSwgZHVlIHRvIHRoZSBsb3cKYW1vdXQgb2YgKHBjaSkgdmlkZW8gbWVtb3J5LgoK Y2hlZXJzLAogIEdlcmQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbdGCIzL (ORCPT ); Mon, 3 Jul 2017 04:55:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273AbdGCIzK (ORCPT ); Mon, 3 Jul 2017 04:55:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 937CFC04B32C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 937CFC04B32C Message-ID: <1499072103.771.7.camel@redhat.com> Subject: Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers From: Gerd Hoffmann To: Mark Cave-Ayland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 03 Jul 2017 10:55:03 +0200 In-Reply-To: References: <1499032363-8290-1-git-send-email-mark.cave-ayland@ilande.co.uk> <20170703081116.rub4ty5ewpi5af3o@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 03 Jul 2017 08:55:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > Hopefully Gerd has experience using bochs_drm with other non-x86 > systems > and can comment further. Just pushed to drm-misc-next, fix is correct. bochs video memory is a pci bar, and the framebuffer is stored there. Using sys instead of cfb is probably a leftover from cirrus, where the framebuffer actually in a shadow copy in system ram, due to the low amout of (pci) video memory. cheers, Gerd