From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:46136 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693AbdGCJxF (ORCPT ); Mon, 3 Jul 2017 05:53:05 -0400 Subject: Patch "net: bgmac: Remove superflous netif_carrier_on()" has been added to the 4.4-stable tree To: f.fainelli@gmail.com, amit.pundir@linaro.org, davem@davemloft.net, gregkh@linuxfoundation.org Cc: , From: Date: Mon, 03 Jul 2017 11:52:43 +0200 Message-ID: <149907556317639@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled net: bgmac: Remove superflous netif_carrier_on() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: net-bgmac-remove-superflous-netif_carrier_on.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 3894396e64994f31c3ef5c7e6f63dded0593e567 Mon Sep 17 00:00:00 2001 From: Florian Fainelli Date: Thu, 23 Jun 2016 14:25:33 -0700 Subject: net: bgmac: Remove superflous netif_carrier_on() From: Florian Fainelli commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream. bgmac_open() calls phy_start() to initialize the PHY state machine, which will set the interface's carrier state accordingly, no need to force that as this could be conflicting with the PHY state determined by PHYLIB. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Amit Pundir Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bgmac.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1308,8 +1308,6 @@ static int bgmac_open(struct net_device phy_start(bgmac->phy_dev); - netif_carrier_on(net_dev); - netif_start_queue(net_dev); return 0; Patches currently in stable-queue which might be from f.fainelli@gmail.com are queue-4.4/net-korina-fix-napi-versus-resources-freeing.patch queue-4.4/arm-dts-bcm5301x-correct-gic_ppi-interrupt-flags.patch queue-4.4/net-bgmac-start-transmit-queue-in-bgmac_open.patch queue-4.4/net-bgmac-fix-sof-bit-checking.patch queue-4.4/net-bgmac-remove-superflous-netif_carrier_on.patch