All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Lock <joshua.g.lock@linux.intel.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>, yocto@yoctoproject.org
Cc: edwin.plauchu.camacho@linux.intel.com,
	monserratx.sedeno.bustos@intel.com
Subject: Re: [yocto-autobuilder][PATCHv2 1/5] buildsteps/BuildImages: Setproperty BUILDIMAGES
Date: Mon, 03 Jul 2017 15:02:35 +0100	[thread overview]
Message-ID: <1499090555.3470.10.camel@linux.intel.com> (raw)
In-Reply-To: <1496764011-3595-1-git-send-email-anibal.limon@linux.intel.com>

On Tue, 2017-06-06 at 10:46 -0500, Aníbal Limón wrote:
> In certain situations is need to know what images was built for
> example the DAFT executes flashing over certain image.
> 
> [YOCTO #10604]
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  lib/python2.7/site-packages/autobuilder/buildsteps/BuildImages.py |
> 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/python2.7/site-
> packages/autobuilder/buildsteps/BuildImages.py b/lib/python2.7/site-
> packages/autobuilder/buildsteps/BuildImages.py
> index 30f7a18..7262fd3 100644
> --- a/lib/python2.7/site-
> packages/autobuilder/buildsteps/BuildImages.py
> +++ b/lib/python2.7/site-
> packages/autobuilder/buildsteps/BuildImages.py
> @@ -146,6 +146,9 @@ class BuildImages(BitbakeShellCommand):
>                  if self.minnowExists is None or self.minnowExists ==
> "True":
>                      self.command = ". ./oe-init-build-env; bitbake "
> + bitbakeflags + self.images
>                      self.description = ["Building " +
> str(self.images)]
> +        
> +        self.setProperty("BUILDIMAGES", self.images)

Generally speaking caps case property names should only be used when
they map to a variable in OE. BuildImages would work.

> +
>          ShellCommand.start(self)
>  
>      def describe(self, done=False):


  parent reply	other threads:[~2017-07-03 14:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 15:46 [yocto-autobuilder][PATCHv2 1/5] buildsteps/BuildImages: Setproperty BUILDIMAGES Aníbal Limón
2017-06-06 15:46 ` [yocto-autobuilder][PATCHv2 2/5] buildsteps/RunSanityTests: Add support for simpleremote target Aníbal Limón
2017-06-06 15:46 ` [yocto-autobuilder][PATCHv2 3/5] autobuilder/buildsteps: Add DaftGetDevices step Aníbal Limón
2017-07-03 14:03   ` Joshua Lock
2017-07-03 16:34     ` Aníbal Limón
2017-06-06 15:46 ` [yocto-autobuilder][PATCHv2 4/5] autobuilder/buildsteps: Add DAFTFlash buildstep Aníbal Limón
2017-06-06 15:48   ` Aníbal Limón
2017-07-03 14:03   ` Joshua Lock
2017-07-03 16:37     ` Aníbal Limón
2017-07-03 18:23       ` Ylinen, Mikko
2017-07-03 19:14         ` Gonzalez Plascencia, Jair De Jesus
2017-06-06 15:46 ` [yocto-autobuilder][PATCHv2 5/5] buildset-config.yocto-qa: Add intel-corei7-64-daft buildset Aníbal Limón
2017-07-03 14:02 ` Joshua Lock [this message]
2017-07-03 16:34   ` [yocto-autobuilder][PATCHv2 1/5] buildsteps/BuildImages: Setproperty BUILDIMAGES Aníbal Limón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499090555.3470.10.camel@linux.intel.com \
    --to=joshua.g.lock@linux.intel.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=edwin.plauchu.camacho@linux.intel.com \
    --cc=monserratx.sedeno.bustos@intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.