Re: [RTDS Patch v3 for Xen4.8]

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1763 bytes --]

On Mon, 2017-07-03 at 11:17 -0500, Haoran Li wrote:
> From: naroahlee <naroahlee@gmail.com>
> 
>  When more than one idle VCPUs that have
>  the same PCPU as their previous running core invoke runq_tickle(),
> they will
>  tickle the same PCPU. The tickled PCPU will only pick at most one
> VCPU, i.e.,
>  the highest-priority one, to execute. The other VCPUs will not be
> scheduled
>  for a period, even when there is an idle core, making these VCPUs
>  unnecessarily starve for one period. Therefore, always make sure
> that we only
>  tickle PCPUs that have not been tickled already.
> 
> Signed-off-by: Haoran Li <naroahlee@gmail.com>
> Reviewed-by:   Meng Xu   <mengxu@cis.upenn.edu>
> 
So, from what I can see from the 'From' tag, and from the pieces of
emails, that appear below the patch, this is some kind of
resubmission/new version, of a patch sent a while back.

However, the subject seems to have changed... Or in any case, the
current subject is no good.

It's also a bit unusual, and definitely not comfortable for people
managing the patch, to have a quoted email conversation below the patch
itself (or so I think). So, please, remove it.

Finally, in that quoted email conversation, I asked for some changes,
and said that, with them done, my Reviewed-by: would stand.

Have you made those changes? If yes, please, mention this somewhere
(Ideally, between the S-o-b, R-b tags and the patch itself, after a
'---' mark).

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel