From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Praveen Kumar <kpraveen.lkml@gmail.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 01/17] rbtree: changes to inline coding conventions with Linux tree
Date: Tue, 4 Jul 2017 10:39:25 +0200 [thread overview]
Message-ID: <1499157565.12805.5.camel@citrix.com> (raw)
In-Reply-To: <595B6CC8020000780016848E@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]
On Tue, 2017-07-04 at 02:24 -0600, Jan Beulich wrote:
> > > > On 03.07.17 at 21:58, <kpraveen.lkml@gmail.com> wrote:
> >
> > The patch inlines the rbtree related files to Linux coding
> > conventions to have
> > limited conflicts in future while porting from Linux tree.
>
> "inlines" has a different meaning most of the time - how about
> "brings in line" (but I'll be happy to be corrected by a native
> speaker)? This would then also call for a change to the subject.
>
Or, "aligns the coding style of rbtree related files to Linux one" (but
I'm also not native speaker, and am happy to defer the final judgment
to someone that is).
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-04 8:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 19:58 [PATCH v4 00/17] xen: common: rbtree: ported updates from Linux tree Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 01/17] rbtree: changes to inline coding conventions with " Praveen Kumar
2017-07-04 8:24 ` Jan Beulich
2017-07-04 8:39 ` Dario Faggioli [this message]
2017-07-14 5:07 ` Praveen Kumar
2017-07-14 10:18 ` Jan Beulich
2017-07-03 19:58 ` [PATCH v4 02/17] rbtree: remove redundant if()-condition in rb_erase() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 03/17] rbtree: empty nodes have no color Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 04/17] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 05/17] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 06/17] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 07/17] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 08/17] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 09/17] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 10/17] rbtree: low level optimizations " Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 11/17] rbtree: coding style adjustments Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 12/17] rbtree: optimize fetching of sibling node Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 13/17] rbtree: add __rb_change_child() helper function Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 14/17] rbtree: place easiest case first in rb_erase() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 15/17] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 16/17] rbtree: low level optimizations in rb_erase() Praveen Kumar
2017-07-03 19:58 ` [PATCH v4 17/17] rbtree: fix typo in comment of rb_insert_color Praveen Kumar
2017-07-04 8:27 ` [PATCH v4 00/17] xen: common: rbtree: ported updates from Linux tree Jan Beulich
2017-07-04 8:45 ` Dario Faggioli
2017-07-14 4:58 ` Praveen Kumar
2017-07-04 8:49 ` Dario Faggioli
2017-07-04 9:14 ` Praveen Kumar
2017-07-14 4:53 ` Praveen Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499157565.12805.5.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kpraveen.lkml@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.