All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,RFC,v1] wdt: Add a glue driver for watchdog
Date: Wed, 05 Jul 2017 22:58:58 +0300	[thread overview]
Message-ID: <1499284738.22624.281.camel@linux.intel.com> (raw)
In-Reply-To: <4185bd15-d25a-a904-00ab-ac6f649c0469@gmx.de>

On Wed, 2017-07-05 at 21:56 +0200, Heinrich Schuchardt wrote:
> On 07/05/2017 07:45 PM, Andy Shevchenko wrote:

> > This is not a working solution, just an opinion to which direction
> > we might go
> > with ugly broken WDT class.
> > 
> > Feel free to ignore, drop, modify, etc.

^^^^^^ DISCLAIMER

> > +	ret = wdt_reset(wdt);
> > +	if (ret)
> > +		printf("Can't reset watchdog device: %d\n", ret);
> 
> I would suggest debug() instead of printf().
> 
> Imagine this being called from an EFI application in a loop. We
> wouldn't
> want to fill the screen with this message.

Thanks for the indeed correct suggestion, though please read a
disclaimer above. I gave up on that.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-07-05 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 17:45 [U-Boot] [RFC PATCH v1] wdt: Add a glue driver for watchdog Andy Shevchenko
2017-07-05 19:56 ` [U-Boot] [U-Boot,RFC,v1] " Heinrich Schuchardt
2017-07-05 19:58   ` Andy Shevchenko [this message]
2017-07-05 20:49 ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499284738.22624.281.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.