Re: [PATCH v1 4/6] vvmx: add hvm_max_vmx_msr_policy

[Sergey Dyasli <sergey.dyasli@citrix.com>]

On Tue, 2017-07-04 at 09:04 -0600, Jan Beulich wrote:
> > > > On 26.06.17 at 12:44, <sergey.dyasli@citrix.com> wrote:
> > 
> > +{
> > +    struct vmx_msr_policy *p = &hvm_max_vmx_msr_policy;
> > +    uint64_t data, *msr;
> > +    u32 default1_bits;
> > +
> > +    *p = raw_vmx_msr_policy;
> > +
> > +    /* XXX: vmcs_revision_id for nested virt */
> 
> There was no such comment (presumably indicating something that
> yet needs doing) in the old code - what's this about? Can't this be
> implemented instead of such a comment be added?

Currently L1 sees vmcs_revision_id value from the H/W MSR. Which is
fine until live migration is concerned. The question is: what should
happen if L1 is migrated to some other H/W with different vmcs id?
One possible solution is to use "virtual vmcs id" in the policy object.

-- 
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel