From: Joshua Lock <joshua.g.lock@linux.intel.com>
To: Stephano Cetola <stephano.cetola@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [yocto-autobuilder][PATCH V4 1/1] ScrapeTargets.py: improve target search algorithm
Date: Thu, 06 Jul 2017 16:27:58 +0100 [thread overview]
Message-ID: <1499354878.32379.12.camel@linux.intel.com> (raw)
In-Reply-To: <20170706150904.GA11164@scetola-mac01.local>
On Thu, 2017-07-06 at 08:09 -0700, Stephano Cetola wrote:
> On 07/06, Joshua Lock wrote:
> > This still leaves us a bit brittle. What if someone adds whitespace
> > around the assignment operator? Could you create a follow-on patch
> > for
> > that?
> >
> > Thanks!
>
> Actually, since the awk command just searches for self.targetsvar now
> instead of ``self.targetsvar="``, it will match even if there are
> spaces between the equal.
Context is important. It's not the awk command, it's the str.replace()
> + targets = targets.replace('%s="' % self.targetsvar, '')
we're going replace 'SOMEVARIABLE="' with '', but what if we get
'SOMEVARIABLE = "' ?
> I did just realize that if the variable is NOT multi-line, e.g.
> REFKIT_CI_POSTBUILD_SELFTESTS, this search will fail because of the
> "next" command.
Ah, yes. That could cause some surprises.
> I'll puzzle over this a bit.
Thanks!
Joshua
prev parent reply other threads:[~2017-07-06 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 21:27 [yocto-autobuilder][PATCH V4 0/1] better matching for refkit ci Stephano Cetola
2017-07-05 21:27 ` [yocto-autobuilder][PATCH V4 1/1] ScrapeTargets.py: improve target search algorithm Stephano Cetola
2017-07-06 10:47 ` Joshua Lock
2017-07-06 15:09 ` Stephano Cetola
2017-07-06 15:27 ` Joshua Lock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499354878.32379.12.camel@linux.intel.com \
--to=joshua.g.lock@linux.intel.com \
--cc=stephano.cetola@linux.intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.