From: Todor Minchev <todor.minchev@linux.intel.com>
To: swee.aun.khor@intel.com
Cc: yocto@yoctoproject.org, saul.wold@intel.com
Subject: Re: [RMC][PATCH v2] RMC: Support x32 build
Date: Thu, 06 Jul 2017 13:08:20 -0700 [thread overview]
Message-ID: <1499371700.7546.27.camel@linux.intel.com> (raw)
In-Reply-To: <1499283599-11297-1-git-send-email-swee.aun.khor@intel.com>
On Wed, 2017-07-05 at 12:39 -0700, swee.aun.khor@intel.com wrote:
> From: sweeaun <swee.aun.khor@intel.com>
>
> RMC efi is needed to compiled as 64 bits even DEFAULTTUNE is x32.
>
> Signed-off-by: sweeaun <swee.aun.khor@intel.com>
> ---
> Makefile.efi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile.efi b/Makefile.efi
> index 4f69dfe..95e0f8c 100644
> --- a/Makefile.efi
> +++ b/Makefile.efi
> @@ -16,6 +16,9 @@ RMC_INSTALL_LIB_PATH := $(RMC_INSTALL_PREFIX)/lib/
>
> RMC_CFLAGS := -DRMC_EFI -Wall -I$(TOPDIR)/inc -fpic -nostdinc -nostdlib -fno-builtin -std=gnu90
>
> +#RMC efi is needed to be compiled as 64 bit even DEFAULTTUNE is x32
> +CC := $(patsubst -mx32, -m64, $(CC))
> +
Since this is not an RMC-specific problem, I believe that we shouldn't
patch the compiler flags in the RMC Makefile. This patch will provide
the desired outcome only when RMC is built with meta-intel. A better
alternative will be to split rmc.bb into rmc.bb (userspace app) and
rmc-efi.bb (efi library) and modify the compiler flags for each recipe.
I will send a patch that does this.
Todor
> all: librmcefi
>
> $(RMC_LIB_OBJ): %.efi.o: %.c
next prev parent reply other threads:[~2017-07-06 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 19:39 [RMC][PATCH v2] RMC: Support x32 build swee.aun.khor
2017-07-06 20:08 ` Todor Minchev [this message]
2017-07-06 20:37 ` Khem Raj
2017-07-06 20:46 ` Todor Minchev
2017-07-06 22:46 ` Minchev, Todor
2017-07-06 23:08 ` Khem Raj
2017-07-07 1:39 ` Khor, Swee Aun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499371700.7546.27.camel@linux.intel.com \
--to=todor.minchev@linux.intel.com \
--cc=saul.wold@intel.com \
--cc=swee.aun.khor@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.