All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/3] wdt: Timeout better to be in microseconds
Date: Fri, 07 Jul 2017 14:15:53 +0300	[thread overview]
Message-ID: <1499426153.22624.299.camel@linux.intel.com> (raw)
In-Reply-To: <CAPnjgZ0=jwh-c0jdkb4CahNFu2qW+ggJXSpkZFcQsW6zESyhnQ@mail.gmail.com>

On Thu, 2017-07-06 at 21:59 -0600, Simon Glass wrote:
> Hi Andy,
> 
> On 5 July 2017 at 11:44, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > Timeout in some abstract ticks is not what we are applying to get
> > deterministic behaviour.
> 
> A tick is always milliseconds in U-Boot, as I understand it.

You see, there is a confusion.
I would like to see units somewhere there, to make it clear.

> 
> > 
> > Convert name to show explicitly that we are using microseconds (for
> > watchdog it's more than precise).
> 
> Do you want microseconds, or is milliseconds enough accuracy? I have a
> hard time imagining a case where a microsecond watchdog timeout is
> useful.

For me ticks sounded like processor cycles (nanosecond-ish).
So, milliseconds are better.

Since I have not much time, feel free to drop, modify, etc.
Thanks for review.

> 
> > 
> > No functional change intended.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/watchdog/wdt-uclass.c | 4 ++--
> >  include/wdt.h                 | 8 ++++----
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> 
> Regards,
> Simon

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-07-07 11:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 17:44 [U-Boot] [PATCH v1 1/3] wdt: Fix spelling Resettting -> Resetting Andy Shevchenko
2017-07-05 17:44 ` [U-Boot] [PATCH v1 2/3] wdt: Timeout better to be in microseconds Andy Shevchenko
2017-07-06  4:16   ` Bin Meng
2017-07-06  4:34   ` Heiko Schocher
2017-07-07  3:59   ` Simon Glass
2017-07-07 11:15     ` Andy Shevchenko [this message]
2017-07-05 17:44 ` [U-Boot] [PATCH v1 3/3] wdt: Unify option of timeout value Andy Shevchenko
2017-07-05 17:50   ` Andy Shevchenko
2017-07-06  4:16   ` Bin Meng
2017-07-06  6:07   ` Heiko Schocher
2017-07-07  3:59   ` Simon Glass
2017-07-07 11:42   ` [U-Boot] [U-Boot,v1,3/3] " Tom Rini
2017-07-06  4:15 ` [U-Boot] [PATCH v1 1/3] wdt: Fix spelling Resettting -> Resetting Bin Meng
2017-07-06  4:29 ` Heiko Schocher
2017-07-07  3:59 ` Simon Glass
2017-07-07 11:42 ` [U-Boot] [U-Boot, v1, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499426153.22624.299.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.