From: Joe Perches <joe@perches.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
santosh@chelsio.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.
Date: Mon, 10 Jul 2017 22:47:40 -0700 [thread overview]
Message-ID: <1499752060.4457.8.camel@perches.com> (raw)
In-Reply-To: <8884bd80-b8d5-1c1e-5235-b0a0c173bc45@gmail.com>
On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote:
> Hi Joe,
>
>
> On Monday 10 July 2017 10:30 PM, Joe Perches wrote:
> > On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote:
> > > attribute_groups are not supposed to change at runtime. All functions
> > > working with attribute_groups provided by <linux/sysfs.h> work
> > > with const attribute_group. So mark the non-const structs as const.
> >
> > I think it's good you are doing all of these.
> >
> > Instead of individually sending these patches, could you
> > please send a patch series for all of these attribute_group
> > patches with a cover letter at the same time?
> >
> > That could make it easier for a trivial maintainer to apply
> > all of these at once and not get some applied and others
> > ignored or dropped on the floor.
> >
>
> Once again, I will send all of patch together, But I have doubt. If it's
> having
> different maintainer. Example- 'net:' subsystem is having a different
> different
> maintainer. So do i need to add all the maintainer in single list. Which
> can confuse
> what patch is for what maintainer. Please suggest me.
Please send individual patches, one per maintainer/subsystem
as a series with a cover letter like:
[PATCH 0/N] treewide: constify attribute_group structures
[PATCH 1/N] chelsio: cxgb3: constify attribute_group
[PATCH 2/N] chelsio: cxgb4: constify attribute_group
...
[PATCH N/N] subsystem: constify attribute_group
next prev parent reply other threads:[~2017-07-11 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 10:34 [PATCH] net: chelsio: cxgb3: constify attribute_group structures Arvind Yadav
2017-07-10 17:00 ` Joe Perches
2017-07-11 5:41 ` Arvind Yadav
2017-07-11 5:47 ` Joe Perches [this message]
2017-07-11 5:53 ` Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499752060.4457.8.camel@perches.com \
--to=joe@perches.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.