From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1] i2c: core: Protect acpi_match_device() against NULL
Date: Tue, 11 Jul 2017 13:14:14 +0300 [thread overview]
Message-ID: <1499768054.22624.338.camel@linux.intel.com> (raw)
In-Reply-To: <20170710182151.xes5biaaj7jwkhzz@ninjato>
On Mon, 2017-07-10 at 20:21 +0200, Wolfram Sang wrote:
> On Sun, Jul 09, 2017 at 04:18:19PM +0300, Andy Shevchenko wrote:
> > On Sun, 2017-07-09 at 16:16 +0300, Andy Shevchenko wrote:
> > > The commit 09b3b246acba
> > > ("i2c: core: Allow empty id_table in ACPI case as well")
> > > brought an additional check for ACPI match table entry, though
> > > missed
> > > NULL check for table itself.
> > >
> > > Do it here by introducing a helper i2c_acpi_match_device().
> > >
> > > Note, we rename some static function in i2c-core-acpi.c to
> > > distinguish
> > > with public API.
> > >
> >
> > Wolfram, feel free to squash it into the original commit if it looks
> > better.
>
> I didn't want to send Linus a branch which too many last minute fixes.
> That's why I dropped the original patch and would like to ask you to
> resend a combined patch after rc1. If it is a bugfix, we will have no
> problems getting it into v4.13 but it seems a bit more testing is
> needed.
Okay, let's do this way.
I may also try to convert existing users (some coccinelle script I
suppose).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-07-11 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 13:16 [PATCH v1] i2c: core: Protect acpi_match_device() against NULL Andy Shevchenko
2017-07-09 13:18 ` Andy Shevchenko
2017-07-10 18:21 ` Wolfram Sang
2017-07-11 10:14 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499768054.22624.338.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.