All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petre Ovidiu PIRCALABU <ppircalabu@bitdefender.com>
To: "tamas@tklengyel.com" <tamas@tklengyel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>,
	"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
	"rcojocaru@bitdefender.com" <rcojocaru@bitdefender.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] x86/monitor: Notify monitor if an emulation fails.
Date: Wed, 12 Jul 2017 08:48:22 +0000	[thread overview]
Message-ID: <1499849302.5098.3.camel@bitdefender.com> (raw)
In-Reply-To: <CABfawhmrZi2QskuPc3t_D5MmFmmmfcFMFhQeBQOkhmEv1w11WQ@mail.gmail.com>

Hi Tamas,

I have corrected it and resent the patch. 

Thank-you very much for pointing it out,
Petre

On Ma, 2017-07-11 at 23:41 -0600, Tamas K Lengyel wrote:
> On Tue, Jul 11, 2017 at 8:53 AM, Petre Pircalabu
> <ppircalabu@bitdefender.com> wrote:
> > 
> > If case of a vm_event with the emulate_flags set, if the
> > instruction
> > cannot be emulated, the monitor should be notified instead of
> > directly
> > injecting a hw exception.
> > This behavior can be used to re-execute an instruction not
> > supported by
> > the emulator using the real processor (e.g. altp2m) instead of just
> > crashing.
> > 
> > Signed-off-by: Petre Pircalabu <ppircalabu@bitdefender.com>
> > 
> > ---
> > Changed since v1:
> >   * Removed the emulation kind check when calling
> > hvm_inject_hw_exception
> > ---
> >  tools/libxc/include/xenctrl.h                      |   2 +
> >  tools/libxc/xc_monitor.c                           |  14 ++
> >  ...itor-Notify-monitor-if-an-emulation-fails.patch | 212
> > +++++++++++++++++++++
> >  xen/arch/x86/hvm/emulate.c                         |   5 +-
> >  xen/arch/x86/hvm/monitor.c                         |  19 ++
> >  xen/arch/x86/monitor.c                             |  12 ++
> >  xen/include/asm-x86/domain.h                       |   1 +
> >  xen/include/asm-x86/hvm/monitor.h                  |   1 +
> >  xen/include/asm-x86/monitor.h                      |   3 +-
> >  xen/include/public/domctl.h                        |   1 +
> >  xen/include/public/vm_event.h                      |   2 +
> >  11 files changed, 270 insertions(+), 2 deletions(-)
> >  create mode 100644 tools/tests/xen-access/0001-x86-monitor-Notify-
> > monitor-if-an-emulation-fails.patch
> I don't think you meant to add this patch file.
> 
> Tamas
> 
> ________________________
> This email was scanned by Bitdefender
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-07-12  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 14:53 [PATCH v2] x86/monitor: Notify monitor if an emulation fails Petre Pircalabu
2017-07-12  5:41 ` Tamas K Lengyel
2017-07-12  8:48   ` Petre Ovidiu PIRCALABU [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499849302.5098.3.camel@bitdefender.com \
    --to=ppircalabu@bitdefender.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=tamas@tklengyel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.