Re: [PATCH] pinctrl: baytrail: Do not call WARN_ON for a firmware bug

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, 2017-07-12 at 16:18 +0200, Hans de Goede wrote:
> On 12-07-17 15:12, Andy Shevchenko wrote:
> > On Wed, 2017-07-12 at 14:44 +0200, Hans de Goede wrote:
> > > On 12-07-17 14:38, Andy Shevchenko wrote:
> > > > On Wed, 2017-07-12 at 14:31 +0200, Hans de Goede wrote:
> > > > > 


> > > that the ACPI tables / or a driver want to use a pin as gpio and
> > > it
> > > has
> > > been setup differently (as a special function) by the firmware.
> > 
> > Yes, and what I'm asking are the details of it, what product, what
> > device needs that pin, and why do we think that is the rightful
> > request
> > from the OS?
> 
> I will need to do some digging to get you these details, I will get
> back to you on that later.

Thanks!

> This discussion really is orthogonal to this patch,

Correct. I would like to know the details to have this knowledge in case
of something similar might happen with other device(s).

>  calling WARN_ON
> for something outside of the control of the kernel clearly is the
> wrong
> thing to do. So in the mean time can I have your ack for this patch ?

As I said, patch is okay to me.

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy