All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Guan Junxiong <guanjunxiong@huawei.com>,
	dm-devel@redhat.com, christophe.varoqui@opensvc.com,
	keith.busch@intel.com
Cc: philip.yang@huawei.com, zouming.zouming@huawei.com,
	hege09@huawei.com, shenhong09@huawei.com
Subject: Re: [PATCH] multipath-tools: don't discard uevent for NVMe-Fabrics device
Date: Thu, 13 Jul 2017 12:04:56 +0200	[thread overview]
Message-ID: <1499940296.6432.1.camel@suse.com> (raw)
In-Reply-To: <1499932023-29852-1-git-send-email-guanjunxiong@huawei.com>

On Thu, 2017-07-13 at 15:47 +0800, Guan Junxiong wrote:
> The devpath of uevent of NVMe-Fabrics device is like this
> "../devices/virtual/nvme-fabrics/ctl/nvme0/nvme0n1" which
> doesn't contains the "/block/" string. So when new uvents
> of such nvme devices arise, the multipathd daemon still ignores
> them, which results the DM-multipath doesn't update the table.
> This patch fixes this by introducing a new helper to filter
> "/block/" and "nvme-fabrics/ctl".
> 
> Signed-off-by: Junxiong Guan <guanjunxiong@huawei.com>

The analysis is correct, but NAK nonetheless for the patch. The whole
uevent_can_discard_by_devpath() approach is broken. I'll send a patch
dropping that function entirely later today.

Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2017-07-13 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13  7:47 [PATCH] multipath-tools: don't discard uevent for NVMe-Fabrics device Guan Junxiong
2017-07-13 10:04 ` Martin Wilck [this message]
2017-07-14 10:49   ` Guan Junxiong
2017-07-14 11:06     ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499940296.6432.1.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=guanjunxiong@huawei.com \
    --cc=hege09@huawei.com \
    --cc=keith.busch@intel.com \
    --cc=philip.yang@huawei.com \
    --cc=shenhong09@huawei.com \
    --cc=zouming.zouming@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.