diff for duplicates of <1499980882.2865.65.camel@kernel.crashing.org> diff --git a/a/1.txt b/N1/1.txt index 6cfbe09..9f94b99 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,22 @@ On Thu, 2017-07-13 at 15:11 -0600, Alex Williamson wrote: -> > > */ -> > > - if (vga_default == NULL && -> > > - ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) { -> > > + if (vga_default == NULL) { -> > > vgaarb_info(&pdev->dev, "setting as boot VGA device\n"); -> > > vga_set_default_device(pdev); -> > > } +> > > ????? */ +> > > -???if (vga_default == NULL && +> > > -?????? ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) { +> > > +???if (vga_default == NULL) { +> > > ?????????????vgaarb_info(&pdev->dev, "setting as boot VGA device\n"); +> > > ?????????????vga_set_default_device(pdev); +> > > ?????}? > > > "Legacy" is the breadcrumb we use to try to pick the same device for -> default VGA as the system firmware used as the boot VGA. There can be +> default VGA as the system firmware used as the boot VGA.? There can be > multiple VGA devices in the system, the change above would simply make -> the first discovered device be the default VGA. That would break many, -> many systems. If legacy VGA ranges mean nothing on ARM64, then follow +> the first discovered device be the default VGA.? That would break many, +> many systems.? If legacy VGA ranges mean nothing on ARM64, then follow > the powerpc lead and make an arch quirk that simply selects the first -> enabled VGA device as the default. VGA routing is part of the PCI spec +> enabled VGA device as the default.? VGA routing is part of the PCI spec > though, so the default of selecting the device with routing enabled -> makes sense. Thanks, +> makes sense.? Thanks, "Legacy" there iirc also means that it has decoding enabled at boot. If you pick the first one you may pick a device that doesn't and hasn't diff --git a/a/content_digest b/N1/content_digest index 425cf7a..efca972 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,42 +3,31 @@ "ref\0EE11001F9E5DDD47B7634E2F8A612F2E40B35F02@FRAEML521-MBX.china.huawei.com\0" "ref\020170713112938.GI4486@bhelgaas-glaptop.roam.corp.google.com\0" "ref\020170713151146.53e9644c@w520.home\0" - "From\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" - "Subject\0Re: [PATCH v4] PCI: Support hibmc VGA cards behind a misbehaving HiSilicon bridge\0" + "From\0benh@kernel.crashing.org (Benjamin Herrenschmidt)\0" + "Subject\0[PATCH v4] PCI: Support hibmc VGA cards behind a misbehaving HiSilicon bridge\0" "Date\0Fri, 14 Jul 2017 07:21:22 +1000\0" - "To\0Alex Williamson <alex.williamson@redhat.com>" - " Bjorn Helgaas <helgaas@kernel.org>\0" - "Cc\0Gabriele Paoloni <gabriele.paoloni@huawei.com>" - Daniel Axtens <dja@axtens.net> - linux-pci@vger.kernel.org <linux-pci@vger.kernel.org> - Liuxinliang (Matthew Liu) <z.liuxinliang@hisilicon.com> - Rongrong Zou <zourongrong@gmail.com> - Catalin Marinas <catalin.marinas@arm.com> - Will Deacon <will.deacon@arm.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - David Airlie <airlied@linux.ie> - " Daniel Vetter <daniel.vetter@intel.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2017-07-13 at 15:11 -0600, Alex Williamson wrote:\n" - "> > > \302\240\302\240\302\240\302\240\302\240 */\n" - "> > > -\302\240\302\240\302\240if (vga_default == NULL &&\n" - "> > > -\302\240\302\240\302\240\302\240\302\240\302\240 ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) {\n" - "> > > +\302\240\302\240\302\240if (vga_default == NULL) {\n" - "> > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240vgaarb_info(&pdev->dev, \"setting as boot VGA device\\n\");\n" - "> > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240vga_set_default_device(pdev);\n" - "> > > \302\240\302\240\302\240\302\240\302\240}\302\240 \n" + "> > > ????? */\n" + "> > > -???if (vga_default == NULL &&\n" + "> > > -?????? ((vgadev->owns & VGA_RSRC_LEGACY_MASK) == VGA_RSRC_LEGACY_MASK)) {\n" + "> > > +???if (vga_default == NULL) {\n" + "> > > ?????????????vgaarb_info(&pdev->dev, \"setting as boot VGA device\\n\");\n" + "> > > ?????????????vga_set_default_device(pdev);\n" + "> > > ?????}? \n" "> \n" "> \n" "> \"Legacy\" is the breadcrumb we use to try to pick the same device for\n" - "> default VGA as the system firmware used as the boot VGA.\302\240 There can be\n" + "> default VGA as the system firmware used as the boot VGA.? There can be\n" "> multiple VGA devices in the system, the change above would simply make\n" - "> the first discovered device be the default VGA.\302\240 That would break many,\n" - "> many systems.\302\240 If legacy VGA ranges mean nothing on ARM64, then follow\n" + "> the first discovered device be the default VGA.? That would break many,\n" + "> many systems.? If legacy VGA ranges mean nothing on ARM64, then follow\n" "> the powerpc lead and make an arch quirk that simply selects the first\n" - "> enabled VGA device as the default.\302\240 VGA routing is part of the PCI spec\n" + "> enabled VGA device as the default.? VGA routing is part of the PCI spec\n" "> though, so the default of selecting the device with routing enabled\n" - "> makes sense.\302\240 Thanks,\n" + "> makes sense.? Thanks,\n" "\n" "\"Legacy\" there iirc also means that it has decoding enabled at boot. If\n" "you pick the first one you may pick a device that doesn't and hasn't\n" @@ -47,4 +36,4 @@ "Cheers,\n" Ben. -112f1bf27c0be5dacfd01e17d7a0f172ed6655224e672f4e27efb2019fdb9638 +71a8d569ca9851d64d08cac5ccb753eb7c141e659569977baa1650b0861c950e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.