From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.securetransport.de (mx3.securetransport.de [116.203.31.6]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6863FF5 for ; Sun, 24 Dec 2023 12:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dh-electronics.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dh-electronics.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dh-electronics.com header.i=@dh-electronics.com header.b="Th+ssTYy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1703422405; bh=Y1CPg8CNk2gRI6NiCH8syYJYW4DBqe188X/z7V1gURA=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Th+ssTYyhbmTAWxKw2PGZih4arkjwL24N9wAfKXMBB3NZzE7DvfETizwBKEpxLc2J NDiBNzlKyWRO7AvUIhahMWLevF2A0azafdhagfBVtyUOEVKBt+js6RI5efyvyI02o2 yjBFTQa4g0cUNP9MVTge+sbFaQft/CUdqIMGa+DJ1lm9r05SZ/CbTvl2YOIDSaHHzJ zwcutEW86Cgkwj7Wu23QtLqsmDD6PNLWGtM1A2GzMpztABqwoVWD3YN3H9ENw5wLKh mM870iMLr7swVAOxkwB/TEM9Wl0ViIcFIbIjYpn2lnC/FNW2yNmVYOkLktOmnKrl6z qqnR2i2dndZOA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Lukas Wunner CC: "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Marek Vasut , Fabio Estevam , Sascha Hauer , "Pengutronix Kernel Team" , NXP Linux Team , "Sergey Organov" , =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Rob Herring , =?utf-8?B?SWxwbyBKw6RydmluZW4=?= , Tom Rix , Thomas Gleixner Subject: RE: [PATCH] serial: imx: Ensure that imx_uart_rs485_config() is called with enabled clock Thread-Topic: [PATCH] serial: imx: Ensure that imx_uart_rs485_config() is called with enabled clock Thread-Index: AQHaNSPuNwSULUnUgEmcck35MrIsuLC4T5YAgAAVwdA= Date: Sun, 24 Dec 2023 12:53:14 +0000 Message-ID: <149f4e1020954e2e91fe1cde0e4afebc@dh-electronics.com> References: <20231222221101.2380-1-cniedermaier@dh-electronics.com> <20231224123254.GA15377@wunner.de> In-Reply-To: <20231224123254.GA15377@wunner.de> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 RnJvbTogTHVrYXMgV3VubmVyIFttYWlsdG86bHVrYXNAd3VubmVyLmRlXQ0KU2VudDogU3VuZGF5 LCBEZWNlbWJlciAyNCwgMjAyMyAxOjMzIFBNDQo+IE9uIEZyaSwgRGVjIDIyLCAyMDIzIGF0IDEx OjExOjAxUE0gKzAxMDAsIENocmlzdG9waCBOaWVkZXJtYWllciB3cm90ZToNCj4+IFRoZXJlIGFy ZSByZWdpc3RlciBhY2Nlc3NlcyBpbiB0aGUgZnVuY3Rpb24gaW14X3VhcnRfcnM0ODVfY29uZmln KCkuIFRoZQ0KPj4gY2xvY2sgbXVzdCBiZSBlbmFibGVkIGZvciB0aGVzZSBhY2Nlc3Nlcy4gVGhp cyB3YXMgZW5zdXJlZCBieSBjYWxsaW5nIGl0DQo+PiB2aWEgdGhlIGZ1bmN0aW9uIHVhcnRfcnM0 ODVfY29uZmlnKCkgaW4gdGhlIHByb2JlKCkgZnVuY3Rpb24gd2l0aGluIHRoZQ0KPj4gcmFuZ2Ug d2hlcmUgdGhlIGNsb2NrIGlzIGVuYWJsZWQuIFdpdGggdGhlIGNvbW1pdCA3YzdmOWJjOTg2ZTYg KCJzZXJpYWw6DQo+PiBEZWFzc2VydCBUcmFuc21pdCBFbmFibGUgb24gcHJvYmUgaW4gZHJpdmVy LXNwZWNpZmljIHdheSIpIGl0IHdhcyByZW1vdmVkDQo+PiBmcm9tIHRoZSBwcm9iZSgpIGZ1bmN0 aW9uIGFuZCBpcyBub3cgb25seSBjYWxsZWQgdGhyb3VnaCB0aGUgZnVuY3Rpb24NCj4+IHVhcnRf YWRkX29uZV9wb3J0KCkgd2hpY2ggaXMgbG9jYXRlZCBhdCB0aGUgZW5kIG9mIHRoZSBwcm9iZSgp IGZ1bmN0aW9uLg0KPj4gQnV0IHRoZSBjbG9jayBpcyBhbHJlYWR5IHN3aXRjaGVkIG9mZiBpbiB0 aGlzIGFyZWEuIFRvIGVuc3VyZSB0aGF0IHRoZQ0KPj4gY2xvY2sgaXMgZW5hYmxlZCBkdXJpbmcg cmVnaXN0ZXIgYWNjZXNzLCBtb3ZlIHRoZSBkaXNhYmxpbmcgb2YgdGhlIGNsb2NrDQo+PiB0byB0 aGUgdmVyeSBlbmQgb2YgdGhlIHByb2JlKCkgZnVuY3Rpb24uDQo+IA0KPiBUaGFua3MgZm9yIGNh dGNoaW5nIHRoaXMgYW5kIHNvcnJ5IGZvciB0aGUgYnJlYWthZ2UuDQo+IA0KPiANCj4+IEBAIC0y NDY3LDcgKzI0NjUsMTEgQEAgc3RhdGljIGludCBpbXhfdWFydF9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQ0KPj4NCj4+ICAgICAgIHBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYs IHNwb3J0KTsNCj4+DQo+PiAtICAgICByZXR1cm4gdWFydF9hZGRfb25lX3BvcnQoJmlteF91YXJ0 X3VhcnRfZHJpdmVyLCAmc3BvcnQtPnBvcnQpOw0KPj4gKyAgICAgcmV0ID0gdWFydF9hZGRfb25l X3BvcnQoJmlteF91YXJ0X3VhcnRfZHJpdmVyLCAmc3BvcnQtPnBvcnQpOw0KPj4gKw0KPj4gKyAg ICAgY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHNwb3J0LT5jbGtfaXBnKTsNCj4+ICsNCj4+ICsgICAg IHJldHVybiByZXQ7DQo+PiAgfQ0KPiANCj4gVGhlcmUgYXJlIGEgYnVuY2ggb2YgcmV0dXJuIHN0 YXRlbWVudHMgaW4gdGhlICJpZiAodHhpcnEgPiAwKSAuLi4gZWxzZSINCj4gY2xhdXNlIGEgbGl0 dGxlIGZ1cnRoZXIgdXAuICBZb3UgbmVlZCB0byBhZGQgYSBnb3RvIGxhYmVsIGluIGZyb250IG9m DQo+IHRoZSAiY2xrX2Rpc2FibGVfdW5wcmVwYXJlKCkiIGFuZCBjaGFuZ2UgdGhlIHJldHVybiBz dGF0ZW1lbnRzIHRvIGdvdG9zDQo+IHRvIGF2b2lkIGxlYWtpbmcgZW5hYmxlZCBjbG9ja3MgaW4g dGhvc2UgZXJyb3IgcGF0aHMuDQoNCllvdSBhcmUgcmlnaHQuIEkgb3Zlcmxvb2tlZCB0aGF0Lg0K SSB3aWxsIGZpeCB0aGF0IGluIHZlcnNpb24gMi4NCiANCg0KVGhhbmtzIGFuZCBSZWdhcmRzDQpD aHJpc3RvcGgNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D894C46CD3 for ; Sun, 24 Dec 2023 12:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V2bVQXzsDM8B/sZON6qc9hchFS/2mfkmUmrZhWMoWIw=; b=YqsXDiZD+b0lY3 CqOLjWF0beuDQYp2jXQd+9nDGuEuq9pX81H3h5ibmORXpz0Gq0IvCtAgXzBA2yOjVDDtpq5in2jvi INEFrXBz2PraIPmlr92otJKWHO1B9vztcRaKENi3lz6oocisO4uE75j4l1V7/L+Hv6ZYkz+BdWeWc 9C0fCOiRrcFCTfAj/LEneCX0FE1X5DwPaZkxntSuqOEFwctrtM1Elcb4InsEMz2Q5jEPuZGYHao+G WtOTsUDCAmex9/MYTKZKM3V8X/OnL1DmMkUevYQMVzrva+ugQ2pkgSIAWlr+GqIEBgymep1HpehSK s7Op8mHXhA81U6riCuzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHNzj-009PkV-2Y; Sun, 24 Dec 2023 12:54:15 +0000 Received: from mx3.securetransport.de ([2a01:4f8:c0c:92be::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHNzf-009PjZ-2Z for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2023 12:54:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1703422405; bh=Y1CPg8CNk2gRI6NiCH8syYJYW4DBqe188X/z7V1gURA=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Th+ssTYyhbmTAWxKw2PGZih4arkjwL24N9wAfKXMBB3NZzE7DvfETizwBKEpxLc2J NDiBNzlKyWRO7AvUIhahMWLevF2A0azafdhagfBVtyUOEVKBt+js6RI5efyvyI02o2 yjBFTQa4g0cUNP9MVTge+sbFaQft/CUdqIMGa+DJ1lm9r05SZ/CbTvl2YOIDSaHHzJ zwcutEW86Cgkwj7Wu23QtLqsmDD6PNLWGtM1A2GzMpztABqwoVWD3YN3H9ENw5wLKh mM870iMLr7swVAOxkwB/TEM9Wl0ViIcFIbIjYpn2lnC/FNW2yNmVYOkLktOmnKrl6z qqnR2i2dndZOA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Lukas Wunner CC: "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Marek Vasut , Fabio Estevam , Sascha Hauer , "Pengutronix Kernel Team" , NXP Linux Team , "Sergey Organov" , =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Rob Herring , =?utf-8?B?SWxwbyBKw6RydmluZW4=?= , Tom Rix , Thomas Gleixner Subject: RE: [PATCH] serial: imx: Ensure that imx_uart_rs485_config() is called with enabled clock Thread-Topic: [PATCH] serial: imx: Ensure that imx_uart_rs485_config() is called with enabled clock Thread-Index: AQHaNSPuNwSULUnUgEmcck35MrIsuLC4T5YAgAAVwdA= Date: Sun, 24 Dec 2023 12:53:14 +0000 Message-ID: <149f4e1020954e2e91fe1cde0e4afebc@dh-electronics.com> References: <20231222221101.2380-1-cniedermaier@dh-electronics.com> <20231224123254.GA15377@wunner.de> In-Reply-To: <20231224123254.GA15377@wunner.de> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231224_045412_117888_004427CB X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Lukas Wunner [mailto:lukas@wunner.de] Sent: Sunday, December 24, 2023 1:33 PM > On Fri, Dec 22, 2023 at 11:11:01PM +0100, Christoph Niedermaier wrote: >> There are register accesses in the function imx_uart_rs485_config(). The >> clock must be enabled for these accesses. This was ensured by calling it >> via the function uart_rs485_config() in the probe() function within the >> range where the clock is enabled. With the commit 7c7f9bc986e6 ("serial: >> Deassert Transmit Enable on probe in driver-specific way") it was removed >> from the probe() function and is now only called through the function >> uart_add_one_port() which is located at the end of the probe() function. >> But the clock is already switched off in this area. To ensure that the >> clock is enabled during register access, move the disabling of the clock >> to the very end of the probe() function. > > Thanks for catching this and sorry for the breakage. > > >> @@ -2467,7 +2465,11 @@ static int imx_uart_probe(struct platform_device *pdev) >> >> platform_set_drvdata(pdev, sport); >> >> - return uart_add_one_port(&imx_uart_uart_driver, &sport->port); >> + ret = uart_add_one_port(&imx_uart_uart_driver, &sport->port); >> + >> + clk_disable_unprepare(sport->clk_ipg); >> + >> + return ret; >> } > > There are a bunch of return statements in the "if (txirq > 0) ... else" > clause a little further up. You need to add a goto label in front of > the "clk_disable_unprepare()" and change the return statements to gotos > to avoid leaking enabled clocks in those error paths. You are right. I overlooked that. I will fix that in version 2. Thanks and Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel