From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1304CC433FE for ; Fri, 11 Dec 2020 16:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4B7423D3C for ; Fri, 11 Dec 2020 16:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730102AbgLKPau (ORCPT ); Fri, 11 Dec 2020 10:30:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388379AbgLKPad (ORCPT ); Fri, 11 Dec 2020 10:30:33 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED03C0613CF; Fri, 11 Dec 2020 07:29:52 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id m5so9424447wrx.9; Fri, 11 Dec 2020 07:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zERc61e6q0jyeQa9DII4Gd3+QcLplYsxEQ++mmlkRqE=; b=kAPBD5ididRwkjsfOLZM27vUwQTDQh5Tvkvr2H9LSKoBN1/Tjgz8j0J7BC6GiT3yc7 rsyYBvQKGPipWFGSkGYpw9QZUY4lU1EFgOdThLzewOMDzFhr3cHdbMFDhQJrrt22YCjE tttxzDbbGnR2C+APmaFEooKNqOlOerIIBqFrJC4X1PTfKg2ugGVKMYVkoT4JLyq5DG52 MFTAeYJfvaTlk6zb7U93xoS37Zasqzn70eLhGHFBUHcuiS0MfGMldYYNBRp76UR20l5J bTVcKDilQoV/mKGAyfGCr4YoVWVPYKBejSiUAk8oVhrRNZvNuMscTS2/DFV6BvmANrNW zk/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zERc61e6q0jyeQa9DII4Gd3+QcLplYsxEQ++mmlkRqE=; b=n17nMdGu9iVj9lZ2NvUoOLbMWCSqwvC0Pv2L9djSWWuOv54N6BsXOv+lrrKxVhSTft u+QaEuz0lX182TNMo8Cmm2vJBqCmJh7x8dX+ev40dLLLmuQHJGH/lTZY0SA9IFPYMy7L 6UbSky3e54k5CRNuhGoHF8CVfxNfJJWFrRO4XxIjKQ2aLCfMEB8hBOp4aIookiIkE9jy 84uN/2uSzzrrPLa+5AH+oV4vEjbyFMk9+wovH15HLahr1yaOw6s7ruUd1U4gSMn6f8WP Wl3hMpTD15zPqmrf5f+HIfvsyDMgS8tD4Py2oX97fNa82VCPvg0tL05HM2HmCs3FrKS0 wyrg== X-Gm-Message-State: AOAM531jBMUyPlKHRdU4XFrccWQG7HRXTCczKUDPnbaJDQC3KJn9ZUci t17fTRrfZvqF2kNYOvYEq+k= X-Google-Smtp-Source: ABdhPJzwPIxc9K6r4gJOoLnDqXZc4XcR3ebtAXpwrJFtq3lWVSRQSceS8zmuKv46R5yN9iv1T3rOmQ== X-Received: by 2002:adf:e64b:: with SMTP id b11mr14391204wrn.257.1607700591324; Fri, 11 Dec 2020 07:29:51 -0800 (PST) Received: from [192.168.74.106] (178-169-161-196.razgrad.ddns.bulsat.com. [178.169.161.196]) by smtp.gmail.com with ESMTPSA id d9sm15262283wrs.26.2020.12.11.07.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 07:29:50 -0800 (PST) Subject: Re: [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level To: Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Michael Turquette , Stephen Boyd , Rob Herring , Lee Jones , Sebastian Reichel , Liam Girdwood , Mark Brown , Andy Gross , Bjorn Andersson , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Matheus Castello , Sebastian Krzyszkowiak , Angus Ainslie , Hans de Goede References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-11-krzk@kernel.org> From: Iskren Chernev Message-ID: <14e52c51-23ab-6877-dcec-2b1add958d71@gmail.com> Date: Fri, 11 Dec 2020 17:29:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201210212534.216197-11-krzk@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/10/20 11:25 PM, Krzysztof Kozlowski wrote: > The Maxim fuel gauge datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU.  The falling edge > interrupt will mostly work but it's not correct. > > Fixes: 45dfa741df86 ("ARM: dts: qcom: msm8974-lge-nexus5: Add fuel gauge") > Signed-off-by: Krzysztof Kozlowski > --- >  arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > index e769f638f205..4c6f54aa9f66 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > @@ -575,7 +575,7 @@ fuelgauge: max17048@36 { >              maxim,rcomp = /bits/ 8 <0x4d>; > >              interrupt-parent = <&msmgpio>; > -            interrupts = <9 IRQ_TYPE_EDGE_FALLING>; > +            interrupts = <9 IRQ_TYPE_LEVEL_LOW>; > >              pinctrl-names = "default"; >              pinctrl-0 = <&fuelgauge_pin>; According to the datasheet for max17048 the ALRT pin is active low, so that looks good. The reason it was implemented EDGE_FALLING is mostly due to fragments taken from downstream, and the fact that it worked :) Acked-by: Iskren Chernev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7184EC433FE for ; Fri, 11 Dec 2020 15:31:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A82622D73 for ; Fri, 11 Dec 2020 15:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A82622D73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EDACk4qnA5joQxy3lcTxtZJt43UHl9F+uqFcaO+ri/Y=; b=dWuvQ4yvcxq5sEk448Xo+QtSi JokbucxmtvaZxgf24IM4smQTjdmfmJhGAAvA4Ld9GU5jBUh8VDlrx8x6gKbFPiEoTRw9EjcaFz1g8 IuvU2tG9zJOOMrfxtXRYqpfjb+r62kqZCdDXKKF9HaVA0qQlNmBW/Pdkly+X499bdOcbHeSW2xZvc bwp2cY23UcA5VOgKQtlnzOFXyLCMFrPChzWXDuwRANamg8n5k5ns2eeRnSI1tjrFIvcU/uW/Nf1bu oI0e01/tqyFmzE93DdFj43559Ig2rcEYqYcXEDRkeLlVaPpCIP0iWyfqVk95PHKj5QapCOvpWTqTf qqvJJcQJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knkMk-0003Af-Q2; Fri, 11 Dec 2020 15:29:54 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knkMi-0003AH-GN for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 15:29:53 +0000 Received: by mail-wr1-x442.google.com with SMTP id c5so5808497wrp.6 for ; Fri, 11 Dec 2020 07:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zERc61e6q0jyeQa9DII4Gd3+QcLplYsxEQ++mmlkRqE=; b=kAPBD5ididRwkjsfOLZM27vUwQTDQh5Tvkvr2H9LSKoBN1/Tjgz8j0J7BC6GiT3yc7 rsyYBvQKGPipWFGSkGYpw9QZUY4lU1EFgOdThLzewOMDzFhr3cHdbMFDhQJrrt22YCjE tttxzDbbGnR2C+APmaFEooKNqOlOerIIBqFrJC4X1PTfKg2ugGVKMYVkoT4JLyq5DG52 MFTAeYJfvaTlk6zb7U93xoS37Zasqzn70eLhGHFBUHcuiS0MfGMldYYNBRp76UR20l5J bTVcKDilQoV/mKGAyfGCr4YoVWVPYKBejSiUAk8oVhrRNZvNuMscTS2/DFV6BvmANrNW zk/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zERc61e6q0jyeQa9DII4Gd3+QcLplYsxEQ++mmlkRqE=; b=b+KJutAZCPwJWwKp07pFNhmWmPyqJRMstTg1bZ1jFP0XP/cFYwHs88o9kVOlo3ct0/ T8DMYuQ1pAKOgdZXbycub8Tk5sxz+vx4CBb7XfFg4gXT7/uUioPWBjNH+IBlxF0nbC2k 5zMGH4MKxGsW/+GnsjKu5tyKvf8kMqqoXbAhWOcHnQ4np0u4izPRfn44zdiFtdKB4J6S XnPE/UKR6ezqJ4uJRdAov2Dhz/FkQbrJkCzhynfZZoZUNcn8pAF7mOqBzEBwTBHLbozQ sh4OpFqoFVrS/Xhse8qxGe4ekPmXzpI22vOWmrLD0cvkHnaTsEpEWjCHZ+eLgI7Ci5OQ rTVg== X-Gm-Message-State: AOAM532DNUuLwWG5XjD0aongdKIjy6bPBjrdDAuz7sL1XRAd99MVglxm zR2MFyQzAArHnTHeNTOJ9G4= X-Google-Smtp-Source: ABdhPJzwPIxc9K6r4gJOoLnDqXZc4XcR3ebtAXpwrJFtq3lWVSRQSceS8zmuKv46R5yN9iv1T3rOmQ== X-Received: by 2002:adf:e64b:: with SMTP id b11mr14391204wrn.257.1607700591324; Fri, 11 Dec 2020 07:29:51 -0800 (PST) Received: from [192.168.74.106] (178-169-161-196.razgrad.ddns.bulsat.com. [178.169.161.196]) by smtp.gmail.com with ESMTPSA id d9sm15262283wrs.26.2020.12.11.07.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 07:29:50 -0800 (PST) Subject: Re: [PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level To: Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Michael Turquette , Stephen Boyd , Rob Herring , Lee Jones , Sebastian Reichel , Liam Girdwood , Mark Brown , Andy Gross , Bjorn Andersson , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-11-krzk@kernel.org> From: Iskren Chernev Message-ID: <14e52c51-23ab-6877-dcec-2b1add958d71@gmail.com> Date: Fri, 11 Dec 2020 17:29:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201210212534.216197-11-krzk@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_102952_610413_D349ABCD X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angus Ainslie , Hans de Goede , Sebastian Krzyszkowiak , Matheus Castello Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDEyLzEwLzIwIDExOjI1IFBNLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgogPiBUaGUg TWF4aW0gZnVlbCBnYXVnZSBkYXRhc2hlZXRzIGRlc2NyaWJlIHRoZSBpbnRlcnJ1cHQgbGluZSBh cyBhY3RpdmUKID4gbG93IHdpdGggYSByZXF1aXJlbWVudCBvZiBhY2tub3dsZWRnZSBmcm9tIHRo ZSBDUFUuwqAgVGhlIGZhbGxpbmcgZWRnZQogPiBpbnRlcnJ1cHQgd2lsbCBtb3N0bHkgd29yayBi dXQgaXQncyBub3QgY29ycmVjdC4KID4KID4gRml4ZXM6IDQ1ZGZhNzQxZGY4NiAoIkFSTTogZHRz OiBxY29tOiBtc204OTc0LWxnZS1uZXh1czU6IEFkZCBmdWVsIApnYXVnZSIpCiA+IFNpZ25lZC1v ZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4KID4gLS0tCiA+wqAg YXJjaC9hcm0vYm9vdC9kdHMvcWNvbS1tc204OTc0LWxnZS1uZXh1czUtaGFtbWVyaGVhZC5kdHMg fCAyICstCiA+wqAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p CiA+CiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQtbGdlLW5l eHVzNS1oYW1tZXJoZWFkLmR0cyAKYi9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQtbGdl LW5leHVzNS1oYW1tZXJoZWFkLmR0cwogPiBpbmRleCBlNzY5ZjYzOGYyMDUuLjRjNmY1NGFhOWY2 NiAxMDA2NDQKID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvcWNvbS1tc204OTc0LWxnZS1uZXh1 czUtaGFtbWVyaGVhZC5kdHMKID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvcWNvbS1tc204OTc0 LWxnZS1uZXh1czUtaGFtbWVyaGVhZC5kdHMKID4gQEAgLTU3NSw3ICs1NzUsNyBAQCBmdWVsZ2F1 Z2U6IG1heDE3MDQ4QDM2IHsKID4gwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqBtYXhpbSxyY29tcCA9 IC9iaXRzLyA4IDwweDRkPjsKID4KID4gwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqBpbnRlcnJ1cHQt cGFyZW50ID0gPCZtc21ncGlvPjsKID4gLcKgwqAgwqDCoMKgIMKgwqDCoCDCoGludGVycnVwdHMg PSA8OSBJUlFfVFlQRV9FREdFX0ZBTExJTkc+OwogPiArwqDCoCDCoMKgwqAgwqDCoMKgIMKgaW50 ZXJydXB0cyA9IDw5IElSUV9UWVBFX0xFVkVMX0xPVz47CiA+CiA+IMKgwqDCoCDCoMKgwqAgwqDC oMKgIMKgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKID4gwqDCoMKgIMKgwqDCoCDCoMKgwqAg wqBwaW5jdHJsLTAgPSA8JmZ1ZWxnYXVnZV9waW4+OwoKQWNjb3JkaW5nIHRvIHRoZSBkYXRhc2hl ZXQgZm9yIG1heDE3MDQ4IHRoZSBBTFJUIHBpbiBpcyBhY3RpdmUgbG93LCBzbyB0aGF0Cmxvb2tz IGdvb2QuIFRoZSByZWFzb24gaXQgd2FzIGltcGxlbWVudGVkIEVER0VfRkFMTElORyBpcyBtb3N0 bHkgZHVlIHRvCmZyYWdtZW50cyB0YWtlbiBmcm9tIGRvd25zdHJlYW0sIGFuZCB0aGUgZmFjdCB0 aGF0IGl0IHdvcmtlZCA6KQoKQWNrZWQtYnk6IElza3JlbiBDaGVybmV2IDxpc2tyZW4uY2hlcm5l dkBnbWFpbC5jb20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=