From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC4FC2D0A3 for ; Wed, 4 Nov 2020 13:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 884262236F for ; Wed, 4 Nov 2020 13:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729787AbgKDNuw (ORCPT ); Wed, 4 Nov 2020 08:50:52 -0500 Received: from wp126.webpack.hosteurope.de ([80.237.132.133]:40526 "EHLO wp126.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbgKDNuw (ORCPT ); Wed, 4 Nov 2020 08:50:52 -0500 Received: from [2003:a:659:3f00:1e6f:65ff:fe31:d1d5] (helo=hermes.fivetechno.de); authenticated by wp126.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kaJBY-0000QJ-Qg; Wed, 04 Nov 2020 14:50:48 +0100 X-Virus-Scanned: by amavisd-new 2.11.1 using newest ClamAV at linuxbbg.five-lan.de Received: from [192.168.34.101] (p5098d998.dip0.t-ipconnect.de [80.152.217.152]) (authenticated bits=0) by hermes.fivetechno.de (8.15.2/8.14.5/SuSE Linux 0.8) with ESMTPSA id 0A4DolqS015853 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 4 Nov 2020 14:50:47 +0100 Subject: Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards To: Marek Szyprowski , Rob Herring , Kukjin Kim , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201104102558.11070-1-m.reichl@fivetechno.de> <5800260a-5332-f627-eb36-32df4fbf05e3@fivetechno.de> <71e4ecca-b980-e224-0fbe-b30330e490fb@samsung.com> From: Markus Reichl Organization: five technologies GmbH Message-ID: <14ebf07b-54cb-64a5-fa34-9ad82da72bd2@fivetechno.de> Date: Wed, 4 Nov 2020 14:50:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <71e4ecca-b980-e224-0fbe-b30330e490fb@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;m.reichl@fivetechno.de;1604497852;bff4b310; X-HE-SMSGID: 1kaJBY-0000QJ-Qg Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Marek, Am 04.11.20 um 14:44 schrieb Marek Szyprowski: > On 04.11.2020 14:13, Marek Szyprowski wrote: >> On 04.11.2020 14:06, Markus Reichl wrote: >>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski: >>>> On 04.11.2020 11:25, Markus Reichl wrote: >>>>> Recently introduced async probe on mmc devices can shuffle block IDs. >>>>> Pin them to fixed values to ease booting in evironments where UUIDs >>>>> ar not practical. >>>>> Use newly introduced aliases for mmcblk devices from [1]. >>>>> >>>>> [1] >>>>> https://patchwork.kernel.org/patch/11747669/ >>>>> >>>>> Signed-off-by: Markus Reichl >>>>> --- >>>>>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++ >>>>>   1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644 >>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi >>>>> @@ -13,6 +13,11 @@ >>>>>   #include "exynos-mfc-reserved-memory.dtsi" >>>>>     / { >>>>> +    aliases { >>>>> +        mmc0 = &sdhci_2; >>>>> +        mmc1 = &mshc_0; >>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC (mshc_0) >>>> and 2 for the SD-card (sdhci_2). >>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from >>> exynos4412.dts)? >> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this >> is not an issue. They cannot be used simultaneously. The latter is just >> faster, the first one has been left there mainly for the software >> compatibility. > > I've thought a bit more on this and I would simply prefer to add generic > MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250, > 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW > bus numbers on all boards. Ok, fine with me. As this is beyond my knowledge I would like leave this task with you. > > Best regards > Gruß, -- Markus Reichl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D948C2D0A3 for ; Wed, 4 Nov 2020 13:52:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DDFB21556 for ; Wed, 4 Nov 2020 13:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u2tTSZqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DDFB21556 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fivetechno.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DrFjDaKHqLYjdh/ii19ocTJUwke9Ie/nJgmaN7EgJ8k=; b=u2tTSZqXr11IOpv5SBvkUaj3k 6mXAAAnd3N6Rld7N37xsxAv5OKJid+endsI5L8BlBiXTvm83WZC163BgINSBTwp+zPwLse3MPJpkF zl48J1rLz2hY/pjzOBWSiJ+Efxi8sylpCDr0GK35Lwsw0x208GX3BaQtPA+xL5aAfznLe/eXNhjmV VlYbeoskyUBQAlJ3ZUFcseXzC7wq8d0E5XG+6vT5o/DrgJhRpCThzcVeCbza5ia2NXJz6JLcc/bWu Va46J4O+EvqoCZMPYm1rX+Hc8TvRotVM0BGm+E5/VlWG280JaqoJ1GiX6s7i/oGbkaNh90Zqxz1kj 2b+9jNe+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJBf-0006c7-5E; Wed, 04 Nov 2020 13:50:55 +0000 Received: from wp126.webpack.hosteurope.de ([80.237.132.133]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJBc-0006b2-AQ for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 13:50:53 +0000 Received: from [2003:a:659:3f00:1e6f:65ff:fe31:d1d5] (helo=hermes.fivetechno.de); authenticated by wp126.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kaJBY-0000QJ-Qg; Wed, 04 Nov 2020 14:50:48 +0100 X-Virus-Scanned: by amavisd-new 2.11.1 using newest ClamAV at linuxbbg.five-lan.de Received: from [192.168.34.101] (p5098d998.dip0.t-ipconnect.de [80.152.217.152]) (authenticated bits=0) by hermes.fivetechno.de (8.15.2/8.14.5/SuSE Linux 0.8) with ESMTPSA id 0A4DolqS015853 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 4 Nov 2020 14:50:47 +0100 Subject: Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards To: Marek Szyprowski , Rob Herring , Kukjin Kim , Krzysztof Kozlowski References: <20201104102558.11070-1-m.reichl@fivetechno.de> <5800260a-5332-f627-eb36-32df4fbf05e3@fivetechno.de> <71e4ecca-b980-e224-0fbe-b30330e490fb@samsung.com> From: Markus Reichl Organization: five technologies GmbH Message-ID: <14ebf07b-54cb-64a5-fa34-9ad82da72bd2@fivetechno.de> Date: Wed, 4 Nov 2020 14:50:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <71e4ecca-b980-e224-0fbe-b30330e490fb@samsung.com> Content-Language: de-DE X-bounce-key: webpack.hosteurope.de; m.reichl@fivetechno.de; 1604497852; bff4b310; X-HE-SMSGID: 1kaJBY-0000QJ-Qg X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_085052_468383_98E4BB44 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyZWssCgpBbSAwNC4xMS4yMCB1bSAxNDo0NCBzY2hyaWViIE1hcmVrIFN6eXByb3dza2k6 Cj4gT24gMDQuMTEuMjAyMCAxNDoxMywgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKPj4gT24gMDQu MTEuMjAyMCAxNDowNiwgTWFya3VzIFJlaWNobCB3cm90ZToKPj4+IEFtIDA0LjExLjIwIHVtIDEz OjI1IHNjaHJpZWIgTWFyZWsgU3p5cHJvd3NraToKPj4+PiBPbiAwNC4xMS4yMDIwIDExOjI1LCBN YXJrdXMgUmVpY2hsIHdyb3RlOgo+Pj4+PiBSZWNlbnRseSBpbnRyb2R1Y2VkIGFzeW5jIHByb2Jl IG9uIG1tYyBkZXZpY2VzIGNhbiBzaHVmZmxlIGJsb2NrIElEcy4KPj4+Pj4gUGluIHRoZW0gdG8g Zml4ZWQgdmFsdWVzIHRvIGVhc2UgYm9vdGluZyBpbiBldmlyb25tZW50cyB3aGVyZSBVVUlEcwo+ Pj4+PiBhciBub3QgcHJhY3RpY2FsLgo+Pj4+PiBVc2UgbmV3bHkgaW50cm9kdWNlZCBhbGlhc2Vz IGZvciBtbWNibGsgZGV2aWNlcyBmcm9tIFsxXS4KPj4+Pj4KPj4+Pj4gWzFdCj4+Pj4+IGh0dHBz Oi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTE3NDc2NjkvCj4+Pj4+Cj4+Pj4+IFNpZ25l ZC1vZmYtYnk6IE1hcmt1cyBSZWljaGwgPG0ucmVpY2hsQGZpdmV0ZWNobm8uZGU+Cj4+Pj4+IC0t LQo+Pj4+PiAgwqAgYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNDQxMi1vZHJvaWQtY29tbW9uLmR0 c2kgfCA1ICsrKysrCj4+Pj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4+ Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9leHlub3M0NDEyLW9kcm9p ZC1jb21tb24uZHRzaQo+Pj4+PiBiL2FyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczQ0MTItb2Ryb2lk LWNvbW1vbi5kdHNpCj4+Pj4+IGluZGV4IGE1YzFjZTFlMzk2Yy4uYWExMGQ1YmM3ZTFjIDEwMDY0 NAo+Pj4+PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9leHlub3M0NDEyLW9kcm9pZC1jb21tb24u ZHRzaQo+Pj4+PiArKysgYi9hcmNoL2FybS9ib290L2R0cy9leHlub3M0NDEyLW9kcm9pZC1jb21t b24uZHRzaQo+Pj4+PiBAQCAtMTMsNiArMTMsMTEgQEAKPj4+Pj4gIMKgICNpbmNsdWRlICJleHlu b3MtbWZjLXJlc2VydmVkLW1lbW9yeS5kdHNpIgo+Pj4+PiAgwqAgwqAgLyB7Cj4+Pj4+ICvCoMKg wqAgYWxpYXNlcyB7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBtbWMwID0gJnNkaGNpXzI7Cj4+Pj4+ ICvCoMKgwqDCoMKgwqDCoCBtbWMxID0gJm1zaGNfMDsKPj4+PiBMaWtlIGluIHRoZSBPZHJvaWRY VTMtZmFtaWx5IHBhdGNoLCBJIHdvdWxkIHVzZSAwIGZvciB0aGUgZU1NQyAobXNoY18wKQo+Pj4+ IGFuZCAyIGZvciB0aGUgU0QtY2FyZCAoc2RoY2lfMikuCj4+PiBIb3cgdG8gZGVhbCB0aGVuIHdp dGggc2RoY2lfMCAoZnJvbSBleHlub3M0LmR0c2kpIHZjLiBtc2hjXzAgKGZyb20KPj4+IGV4eW5v czQ0MTIuZHRzKT8KPj4gc2RoY2lfMCBhbmQgbXNoY18wIGJvdGggb3BlcmF0ZSBvbiB0aGUgc2Ft ZSBwaHlzaWNhbCBNTUMwIGJ1cywgc28gdGhpcwo+PiBpcyBub3QgYW4gaXNzdWUuIFRoZXkgY2Fu bm90IGJlIHVzZWQgc2ltdWx0YW5lb3VzbHkuIFRoZSBsYXR0ZXIgaXMganVzdAo+PiBmYXN0ZXIs IHRoZSBmaXJzdCBvbmUgaGFzIGJlZW4gbGVmdCB0aGVyZSBtYWlubHkgZm9yIHRoZSBzb2Z0d2Fy ZQo+PiBjb21wYXRpYmlsaXR5Lgo+IAo+IEkndmUgdGhvdWdodCBhIGJpdCBtb3JlIG9uIHRoaXMg YW5kIEkgd291bGQgc2ltcGx5IHByZWZlciB0byBhZGQgZ2VuZXJpYwo+IE1NQyBhbGlhc2VzIHRv IHRoZSB0b3AtbGV2ZWwgRXh5bm9zIGR0c2kgZmlsZXMgKDMyNTAsIDQyMTAsIDQ0MTIsIDUyNTAs Cj4gNTQxMCwgNTQyMCkgdG8ga2VlcCBMaW51eCBsb2dpY2FsIE1NQyBidXMgbnVtYmVycyBpbiBz eW5jIHdpdGggdGhlIEhXCj4gYnVzIG51bWJlcnMgb24gYWxsIGJvYXJkcy4KCk9rLCBmaW5lIHdp dGggbWUuCkFzIHRoaXMgaXMgYmV5b25kIG15IGtub3dsZWRnZSBJIHdvdWxkIGxpa2UgbGVhdmUg dGhpcyB0YXNrIHdpdGggeW91LgoKPiAKPiBCZXN0IHJlZ2FyZHMKPiAKCkdydcOfLAotLSAKTWFy a3VzIFJlaWNobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=