From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: npiggin@gmail.com
Subject: Re: [PATCH 1/4] powerpc/mm/radix: Don't iterate all sets when flushing the PWC
Date: Fri, 14 Jul 2017 17:21:23 +1000 [thread overview]
Message-ID: <1500016883.2865.82.camel@kernel.crashing.org> (raw)
In-Reply-To: <87shhzpkiq.fsf@skywalker.in.ibm.com>
On Fri, 2017-07-14 at 12:33 +0530, Aneesh Kumar K.V wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > On Fri, 2017-07-14 at 11:11 +0530, Aneesh Kumar K.V wrote:
> > > With the current code, we use tlbiel_pwc() for doing a pwc flush.
> > > and that does what is done this patch. May be we can update this patch
> > > such that we drop tlbiel_pwc and switch all those instance to
> > > tlbiel_pid(pid, RIC_FLUSH_PWC) ?
> > >
> > > You already do this in a later patch.
> >
> > Right, I do it in a later latch and I prefer to keep it this way, to
> > avoid doing too many changes in a single patch.
>
> The commit message do indicate that we don't do flushing correctly for
> PWC flush with the current code. That is not correct. May be update the
> commit message then ?
Yeah ok.
Ben.
prev parent reply other threads:[~2017-07-14 7:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 1:52 [PATCH 1/4] powerpc/mm/radix: Don't iterate all sets when flushing the PWC Benjamin Herrenschmidt
2017-07-14 1:52 ` [PATCH 2/4] powerpc/mm/radix: Improve TLB/PWC flushes Benjamin Herrenschmidt
2017-07-14 1:52 ` [PATCH 3/4] powerpc/mm/radix: Avoid flushing the PWC on every flush_tlb_range Benjamin Herrenschmidt
2017-07-14 5:44 ` Aneesh Kumar K.V
2017-07-14 6:22 ` Benjamin Herrenschmidt
2017-07-17 12:12 ` kbuild test robot
2017-07-14 1:52 ` [PATCH 4/4] powerpc/mm/radix: Workaround prefetch issue with KVM Benjamin Herrenschmidt
2017-07-14 5:51 ` Aneesh Kumar K.V
2017-07-14 6:25 ` Benjamin Herrenschmidt
2017-07-14 6:49 ` [PATCH v2] " Benjamin Herrenschmidt
2017-07-17 5:10 ` Aneesh Kumar K.V
2017-07-19 2:29 ` [PATCH 4/4] " Balbir Singh
2017-07-19 3:54 ` Benjamin Herrenschmidt
2017-07-14 5:41 ` [PATCH 1/4] powerpc/mm/radix: Don't iterate all sets when flushing the PWC Aneesh Kumar K.V
2017-07-14 6:21 ` Benjamin Herrenschmidt
2017-07-14 7:03 ` Aneesh Kumar K.V
2017-07-14 7:21 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500016883.2865.82.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.