All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: Pierre FICHEUX <pierre.ficheux@smile.fr>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH] Added missing CPPFLAGS/CFLAGS/LDFLAGS in sample recipe for morty branch
Date: Mon, 17 Jul 2017 09:04:07 -0500	[thread overview]
Message-ID: <1500300247.5349.105.camel@linux.intel.com> (raw)
In-Reply-To: <1500278455-5712-1-git-send-email-pierre.ficheux@smile.fr>

On Mon, 2017-07-17 at 10:00 +0200, Pierre FICHEUX wrote:
> This problem causes the following error :
> 
> ERROR: example-0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary
> 
> 
> Signed-off-by: Pierre FICHEUX <pierre.ficheux@smile.fr>
> ---
>  .../target/arch/layer/recipes-example/example/example-recipe-0.1.bb    | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb b/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
> index 5fbf594..2c478ad 100644
> --- a/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
> +++ b/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
> @@ -14,7 +14,8 @@ SRC_URI = "file://helloworld.c"
>  S = "${WORKDIR}"
>  
>  do_compile() {
> -	     ${CC} helloworld.c -o helloworld
> +	     ${CC} ${CPPFLAGS} ${CFLAGS} -c helloworld.c -o helloworld.o
> +	     ${CC} ${LDFLAGS} helloworld.o -o helloworld

master has the second line (LDFLAGS) but not the first one (CPPFLAGS and
CFLAGS) so the problem may also be present on master. Would you mind
checking this and sent patches to the poky mailing list?

Leo

>  }
>  
>  do_install() {
> -- 
> 2.7.4
> 




  parent reply	other threads:[~2017-07-17 13:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  8:00 [PATCH] Added missing CPPFLAGS/CFLAGS/LDFLAGS in sample recipe for morty branch Pierre FICHEUX
2017-07-17 10:24 ` Burton, Ross
2017-07-17 10:25 ` Thomas A. F. Thorne MEng AUS MIET
2017-07-17 10:46   ` Burton, Ross
2017-07-17 10:54     ` Thomas A. F. Thorne MEng AUS MIET
2017-07-17 14:04 ` Leonardo Sandoval [this message]
2017-07-17 14:30   ` Burton, Ross
2017-07-17 14:48     ` Leonardo Sandoval
2017-07-17 22:48       ` Pierre FICHEUX
2017-07-26  6:06       ` Einar Vading
2017-07-30 12:10         ` Pierre FICHEUX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500300247.5349.105.camel@linux.intel.com \
    --to=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=pierre.ficheux@smile.fr \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.