From: Oliver Neukum <oneukum@suse.com>
To: jeffy <jeffy.chen@rock-chips.com>, Marcel Holtmann <marcel@holtmann.org>
Cc: briannorris@chromium.org, dianders@chromium.org,
Johan Hedberg <johan.hedberg@gmail.com>,
xiyou.wangcong@gmail.com,
"Gustavo F. Padovan" <gustavo@padovan.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred
Date: Tue, 18 Jul 2017 11:41:41 +0200 [thread overview]
Message-ID: <1500370901.502.6.camel@suse.com> (raw)
In-Reply-To: <596DD6AE.2030704@rock-chips.com>
Am Dienstag, den 18.07.2017, 17:36 +0800 schrieb jeffy:
> Hi Oliver,
>
> On 07/18/2017 04:41 PM, Oliver Neukum wrote:
> >
> > Am Dienstag, den 18.07.2017, 16:08 +0800 schrieb jeffy:
> > >
> > > >
> > > > I am afraid not. We cannot silently drop one part of a transmission.
> > > > I am afraid that the correct algorithm, if we encounter an error at
> > > > that stage, is to abort the operation and report an error.
> > > >
> > > so i should break the loop when error happens right?
> >
> > Yes
> ok, i'll do that.
> >
> >
> > >
> > >
> > > and i uploaded 2 version of patches, which one do you prefer to go on?
> >
> > Where to?
> https://patchwork.kernel.org/patch/9847037
> and
> https://patchwork.kernel.org/patch/9846617
I think that as soon as one URB fails, you should not even try
to submit any other deferred URBs. You are taking one out from
the middle of a sequence. That cannot be right.
Regards
Oliver
next prev parent reply other threads:[~2017-07-18 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 2:06 [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred Jeffy Chen
2017-07-18 6:44 ` Marcel Holtmann
2017-07-18 7:30 ` Oliver Neukum
2017-07-18 8:08 ` jeffy
2017-07-18 8:41 ` Oliver Neukum
2017-07-18 9:36 ` jeffy
2017-07-18 9:41 ` Oliver Neukum [this message]
2017-07-18 9:56 ` jeffy
2017-07-18 12:29 ` Oliver Neukum
2017-07-18 13:13 ` jeffy
-- strict thread matches above, loose matches on Subject: below --
2017-07-18 2:05 Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500370901.502.6.camel@suse.com \
--to=oneukum@suse.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=gustavo@padovan.org \
--cc=jeffy.chen@rock-chips.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.