From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: davem@davemloft.net, stas.yakovlev@gmail.com,
kvalo@codeaurora.org, sgruszka@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: [PATCH v3 07/10] wireless: iwlegacy: Constify attribute_group structures.
Date: Tue, 18 Jul 2017 15:15:02 +0530 [thread overview]
Message-ID: <1500371102-14758-4-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500371102-14758-1-git-send-email-arvind.yadav.cs@gmail.com>
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
Changes in v3:
net-next was closed. Now resubmitting it.
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 5b51fba..de9b652 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -4654,7 +4654,7 @@ static DEVICE_ATTR(tx_power, S_IWUSR | S_IRUGO, il4965_show_tx_power,
NULL
};
-static struct attribute_group il_attribute_group = {
+static const struct attribute_group il_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = il_sysfs_entries,
};
--
1.9.1
next prev parent reply other threads:[~2017-07-18 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 9:44 [PATCH v3 04/10] wireless: ipw2200: constify attribute_group structures Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 05/10] wireless: ipw2100: " Arvind Yadav
2017-07-18 9:45 ` [PATCH v3 06/10] wireless: iwlegacy: " Arvind Yadav
2017-07-18 9:45 ` Arvind Yadav [this message]
2017-07-28 15:06 ` [v3,04/10] ipw2200: " Kalle Valo
2017-07-28 15:08 ` Kalle Valo
2017-07-28 16:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500371102-14758-4-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.