From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result Date: Tue, 18 Jul 2017 14:28:28 +0300 Message-ID: <1500377308.1351.5.camel@linux.intel.com> References: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> <8760eqb3fr.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8760eqb3fr.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Daniel Vetter , David Airlie List-Id: dri-devel@lists.freedesktop.org SGV5LAoKT24gVHVlLCAyMDE3LTA3LTE4IGF0IDEwOjM4ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90 ZToKPiBPbiBNb24sIDE3IEp1bCAyMDE3LCBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxr b3dza2lAbGludXguaW50ZWwuCj4gY29tPiB3cm90ZToKPiA+IFRoaXMgYWRkcyB0aGUgY29ubmVj dG9yIG5hbWUgd2hlbiBwcmludGluZyBhIGRlYnVnIG1lc3NhZ2UgYWJvdXQgdGhlCj4gPiBEUAo+ ID4gbGluayB0cmFpbmluZyByZXN1bHQuIEl0IGlzIHVzZWZ1bCB0byBmaWd1cmUgb3V0IHdoYXQg Y29ubmVjdG9yIGlzCj4gPiBmYWlsaW5nIHdoZW4gbXVsdGlwbGUgRFAgY29ubmVjdG9ycyBhcmUg dXNlZC4KPiAKPiBQZXJoYXBzIG1vcmUgY29uc2lzdGVudCB3b3VsZCBiZSB1c2luZyBhIHByZWZp eCBsaWtlIHRoaXM6Cj4gCj4gCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIGJsYSBi bGEgYmxhYVxuIiwKPiAgICAgICAgIAljb25uZWN0b3ItPmJhc2UuYmFzZS5pZCwgY29ubmVjdG9y LT5iYXNlLm5hbWUpOwoKWW91IGFyZSBkZWZpbml0ZWx5IHJpZ2h0LCB0aGlzIGlzIHdoYXQgaXMg dXNlZCBhbGwgb3ZlciB0aGUgcGxhY2UgaW4gdGhlCmRyaXZlciwgc28gSSBzaG91bGQgc3RpY2sg dG8gaXQuCgpUaGFua3MgZm9yIHRoZSBzdWdnZXN0aW9uLCBJIHdpbGwgc2VuZCBvdXQgdjIgaW4g dGhhdCBkaXJlY3Rpb24gc2hvcnRseS4KCkNoZWVycywKClBhdWwKCj4gPiBTaWduZWQtb2ZmLWJ5 OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAbGludXguaW50ZWwuY29tPgo+ ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5j IHwgMTAgKysrKysrLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDQg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9saW5rX3RyYWluaW5nLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBfbGlua190cmFpbmluZy5jCj4gPiBpbmRleCBiNzljMWMwZTQwNGMuLjc1YTQxMWM5NGNlNSAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5p bmcuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmlu Zy5jCj4gPiBAQCAtMzIxLDEzICszMjEsMTUgQEAgaW50ZWxfZHBfc3RhcnRfbGlua190cmFpbihz dHJ1Y3QgaW50ZWxfZHAKPiA+ICppbnRlbF9kcCkKPiA+ICAJaWYgKCFpbnRlbF9kcF9saW5rX3Ry YWluaW5nX2NoYW5uZWxfZXF1YWxpemF0aW9uKGludGVsX2RwKSkKPiA+ICAJCWdvdG8gZmFpbHVy ZV9oYW5kbGluZzsKPiA+ICAKPiA+IC0JRFJNX0RFQlVHX0tNUygiTGluayBUcmFpbmluZyBQYXNz ZWQgYXQgTGluayBSYXRlID0gJWQsIExhbmUKPiA+IGNvdW50ID0gJWQiLAo+ID4gLQkJICAgICAg aW50ZWxfZHAtPmxpbmtfcmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+ID4gKwlEUk1fREVC VUdfS01TKCJMaW5rIFRyYWluaW5nIFBhc3NlZCBhdCBMaW5rIFJhdGUgPSAlZCwgTGFuZQo+ID4g Y291bnQgPSAlZCBmb3IgY29ubmVjdG9yICVzIiwKPiA+ICsJCSAgICAgIGludGVsX2RwLT5saW5r X3JhdGUsIGludGVsX2RwLT5sYW5lX2NvdW50LAo+ID4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9y LT5iYXNlLm5hbWUpOwo+ID4gIAlyZXR1cm47Cj4gPiAgCj4gPiAgIGZhaWx1cmVfaGFuZGxpbmc6 Cj4gPiAtCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgZmFpbGVkIGF0IGxpbmsgcmF0ZSA9 ICVkLCBsYW5lCj4gPiBjb3VudCA9ICVkIiwKPiA+IC0JCSAgICAgIGludGVsX2RwLT5saW5rX3Jh dGUsIGludGVsX2RwLT5sYW5lX2NvdW50KTsKPiA+ICsJRFJNX0RFQlVHX0tNUygiTGluayBUcmFp bmluZyBmYWlsZWQgYXQgbGluayByYXRlID0gJWQsIGxhbmUKPiA+IGNvdW50ID0gJWQgZm9yIGNv bm5lY3RvciAlcyIsCj4gPiArCQkgICAgICBpbnRlbF9kcC0+bGlua19yYXRlLCBpbnRlbF9kcC0+ bGFuZV9jb3VudCwKPiA+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiA+ ICAJaWYgKCFpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFja192YWx1ZXMoaW50ZWxfZHAs Cj4gPiAgCQkJCQkJICAgICBpbnRlbF9kcC0KPiA+ID5saW5rX3JhdGUsCj4gPiAgCQkJCQkJICAg ICBpbnRlbF9kcC0KPiA+ID5sYW5lX2NvdW50KSkKPiAKPiAKLS0gClBhdWwgS29jaWFsa293c2tp IDxwYXVsLmtvY2lhbGtvd3NraUBsaW51eC5pbnRlbC5jb20+CkludGVsIEZpbmxhbmQgT3kgLSBC SUMgMDM1NzYwNi00IC0gV2VzdGVuZGlua2F0dSA3LCAwMjE2MCBFc3BvbywgRmlubGFuZApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbdGRL2f (ORCPT ); Tue, 18 Jul 2017 07:28:35 -0400 Received: from mga03.intel.com ([134.134.136.65]:40218 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdGRL2d (ORCPT ); Tue, 18 Jul 2017 07:28:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="1173877325" Message-ID: <1500377308.1351.5.camel@linux.intel.com> Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result From: Paul Kocialkowski To: Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Manasi Navare , Daniel Vetter , David Airlie Date: Tue, 18 Jul 2017 14:28:28 +0300 In-Reply-To: <8760eqb3fr.fsf@intel.com> References: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com> <8760eqb3fr.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, On Tue, 2017-07-18 at 10:38 +0300, Jani Nikula wrote: > On Mon, 17 Jul 2017, Paul Kocialkowski com> wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connector is > > failing when multiple DP connectors are used. > > Perhaps more consistent would be using a prefix like this: > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", > connector->base.base.id, connector->base.name); You are definitely right, this is what is used all over the place in the driver, so I should stick to it. Thanks for the suggestion, I will send out v2 in that direction shortly. Cheers, Paul > > Signed-off-by: Paul Kocialkowski > > --- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c > > b/drivers/gpu/drm/i915/intel_dp_link_training.c > > index b79c1c0e404c..75a411c94ce5 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp > > *intel_dp) > > if (!intel_dp_link_training_channel_equalization(intel_dp)) > > goto failure_handling; > > > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > return; > > > > failure_handling: > > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > if (!intel_dp_get_link_train_fallback_values(intel_dp, > > intel_dp- > > >link_rate, > > intel_dp- > > >lane_count)) > > -- Paul Kocialkowski Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland