From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Date: Wed, 19 Jul 2017 11:33:07 +0300 Message-ID: <1500453187.1329.3.camel@linux.intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> <20170718192036.GB6173@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170718192036.GB6173@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE3LTA3LTE4IGF0IDEyOjIwIC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ IE9uIFR1ZSwgSnVsIDE4LCAyMDE3IGF0IDA1OjI1OjM2UE0gKzAzMDAsIFBhdWwgS29jaWFsa293 c2tpIHdyb3RlOgo+ID4gVGhpcyBhZGRzIHRoZSBjb25uZWN0b3IgbmFtZSB3aGVuIHByaW50aW5n IGEgZGVidWcgbWVzc2FnZSBhYm91dCB0aGUKPiA+IERQCj4gPiBsaW5rIHRyYWluaW5nIHJlc3Vs dC4gSXQgaXMgdXNlZnVsIHRvIGZpZ3VyZSBvdXQgd2hhdCBjb25uZWN0b3IgaXMKPiA+IGZhaWxp bmcgd2hlbiBtdWx0aXBsZSBEUCBjb25uZWN0b3JzIGFyZSB1c2VkLgo+ID4gCj4gCj4gVGhhbmtz IGZvciB0aGUgcGF0Y2gsIHRoaXMgZG9lcyBtYWtlIHNlbnNlIGR1cmluZyB0aGUgbGluayB0cmFp bmluZwo+IGZhaWx1cmUgZGVidWdnaW5nIHRvIGtub3cgdGhlIGNvbm5lY3RvciBuYW1lLgo+IFdo aWxlIGF0IGl0IGZlZWwgZnJlZSB0byBjaGFuZ2UgIkZhaWxlZCIsICJMaW5rIFJhdGUsIExhbmUg Q291bnQiLCB0bwo+IHVwcGVyIGNhc2UKPiBpbiB0aGUgZmFpbHVyZV9oYW5kbGluZyBjYXNlIHRv IGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgcGFzcyBjYXNlLgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3 IQoKTm93IHRoYXQgdGhlIHBhdGNoIHdhcyBtZXJnZWQsIGRvIHlvdSBmZWVsIGxpa2UgSSBzaG91 bGQgbWFrZSBhIGZvbGxvdy0KdXAgcGF0Y2ggdG8gZml4IGNvbnNpc3RlbmN5IGluIHRoZSB1cHBl ciBjYXNlIHVzZSBvciBpcyBpdCBlbm91Z2ggb2YgYQpkZXRhaWwgdGhhdCB3ZSBjYW4ganVzdCBm b3JnZXQgYWJvdXQgaXQ/Cgo+IFJldmlld2VkLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5u YXZhcmVAaW50ZWwuY29tPgo+IAo+IE1hbmFzaQo+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBL b2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYyB8IDggKysr KysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlu a190cmFpbmluZy5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJh aW5pbmcuYwo+ID4gaW5kZXggYjc5YzFjMGU0MDRjLi4wNTkwN2ZhOGE1NTMgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9saW5rX3RyYWluaW5nLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYwo+ID4gQEAg LTMyMSwxMiArMzIxLDE2IEBAIGludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oc3RydWN0IGludGVs X2RwCj4gPiAqaW50ZWxfZHApCj4gPiAgCWlmICghaW50ZWxfZHBfbGlua190cmFpbmluZ19jaGFu bmVsX2VxdWFsaXphdGlvbihpbnRlbF9kcCkpCj4gPiAgCQlnb3RvIGZhaWx1cmVfaGFuZGxpbmc7 Cj4gPiAgCj4gPiAtCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgUGFzc2VkIGF0IExpbmsg UmF0ZSA9ICVkLCBMYW5lCj4gPiBjb3VudCA9ICVkIiwKPiA+ICsJRFJNX0RFQlVHX0tNUygiW0NP Tk5FQ1RPUjolZDolc10gTGluayBUcmFpbmluZyBQYXNzZWQgYXQKPiA+IExpbmsgUmF0ZSA9ICVk LCBMYW5lIGNvdW50ID0gJWQiLAo+ID4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLmJh c2UuaWQsCj4gPiArCQkgICAgICBpbnRlbF9jb25uZWN0b3ItPmJhc2UubmFtZSwKPiA+ICAJCSAg ICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGludGVsX2RwLT5sYW5lX2NvdW50KTsKPiA+ICAJcmV0 dXJuOwo+ID4gIAo+ID4gICBmYWlsdXJlX2hhbmRsaW5nOgo+ID4gLQlEUk1fREVCVUdfS01TKCJM aW5rIFRyYWluaW5nIGZhaWxlZCBhdCBsaW5rIHJhdGUgPSAlZCwgbGFuZQo+ID4gY291bnQgPSAl ZCIsCj4gPiArCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIExpbmsgVHJhaW5pbmcg ZmFpbGVkIGF0Cj4gPiBsaW5rIHJhdGUgPSAlZCwgbGFuZSBjb3VudCA9ICVkIiwKPiA+ICsJCSAg ICAgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5iYXNlLmlkLAo+ID4gKwkJICAgICAgaW50ZWxfY29u bmVjdG9yLT5iYXNlLm5hbWUsCj4gPiAgCQkgICAgICBpbnRlbF9kcC0+bGlua19yYXRlLCBpbnRl bF9kcC0+bGFuZV9jb3VudCk7Cj4gPiAgCWlmICghaW50ZWxfZHBfZ2V0X2xpbmtfdHJhaW5fZmFs bGJhY2tfdmFsdWVzKGludGVsX2RwLAo+ID4gIAkJCQkJCSAgICAgaW50ZWxfZHAtCj4gPiA+bGlu a19yYXRlLAo+ID4gLS0gCj4gPiAyLjEzLjIKPiA+IAotLSAKUGF1bCBLb2NpYWxrb3dza2kgPHBh dWwua29jaWFsa293c2tpQGxpbnV4LmludGVsLmNvbT4KSW50ZWwgRmlubGFuZCBPeSAtIEJJQyAw MzU3NjA2LTQgLSBXZXN0ZW5kaW5rYXR1IDcsIDAyMTYwIEVzcG9vLCBGaW5sYW5kCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328AbdGSIdO (ORCPT ); Wed, 19 Jul 2017 04:33:14 -0400 Received: from mga04.intel.com ([192.55.52.120]:11447 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdGSIdM (ORCPT ); Wed, 19 Jul 2017 04:33:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,380,1496127600"; d="scan'208";a="128448046" Message-ID: <1500453187.1329.3.camel@linux.intel.com> Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result From: Paul Kocialkowski To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , David Airlie Date: Wed, 19 Jul 2017 11:33:07 +0300 In-Reply-To: <20170718192036.GB6173@intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> <20170718192036.GB6173@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connector is > > failing when multiple DP connectors are used. > > > > Thanks for the patch, this does make sense during the link training > failure debugging to know the connector name. > While at it feel free to change "Failed", "Link Rate, Lane Count", to > upper case > in the failure_handling case to be consistent with the pass case. Thanks for the review! Now that the patch was merged, do you feel like I should make a follow- up patch to fix consistency in the upper case use or is it enough of a detail that we can just forget about it? > Reviewed-by: Manasi Navare > > Manasi > > > Signed-off-by: Paul Kocialkowski > > --- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c > > b/drivers/gpu/drm/i915/intel_dp_link_training.c > > index b79c1c0e404c..05907fa8a553 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp > > *intel_dp) > > if (!intel_dp_link_training_channel_equalization(intel_dp)) > > goto failure_handling; > > > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d", > > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at > > Link Rate = %d, Lane count = %d", > > + intel_connector->base.base.id, > > + intel_connector->base.name, > > intel_dp->link_rate, intel_dp->lane_count); > > return; > > > > failure_handling: > > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d", > > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at > > link rate = %d, lane count = %d", > > + intel_connector->base.base.id, > > + intel_connector->base.name, > > intel_dp->link_rate, intel_dp->lane_count); > > if (!intel_dp_get_link_train_fallback_values(intel_dp, > > intel_dp- > > >link_rate, > > -- > > 2.13.2 > > -- Paul Kocialkowski Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland