From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lyude Paul <lyude@redhat.com>
Subject: Re: [PATCH v3 3/3] drm/mst: Avoid processing partially received
 up/down message transactions
Date: Wed, 19 Jul 2017 14:16:27 -0400
Message-ID: <1500488187.3548.8.camel@redhat.com>
References: <20170719114330.26540-4-imre.deak@intel.com>
 <20170719134632.13366-1-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 085DA6E57A
 for <dri-devel@lists.freedesktop.org>; Wed, 19 Jul 2017 18:16:29 +0000 (UTC)
In-Reply-To: <20170719134632.13366-1-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>, dri-devel@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAyMDE3LTA3LTE5IGF0IDE2OjQ2ICswMzAwLCBJbXJlIERlYWsgd3JvdGU6Cj4gQ3Vy
cmVudGx5IHdlIG1heSBwcm9jZXNzIHVwL2Rvd24gbWVzc2FnZSB0cmFuc2FjdGlvbnMgY29udGFp
bmluZwo+IHVuaW5pdGlhbGl6ZWQgZGF0YS4gVGhpcyBjYW4gaGFwcGVuIGlmIHRoZXJlIHdhcyBh
biBlcnJvciBkdXJpbmcgdGhlCj4gcmVjZXB0aW9uIG9mIGFueSBtZXNzYWdlIGluIHRoZSB0cmFu
c2FjdGlvbiwgYnV0IHdlIGhhcHBlbmVkIHRvCj4gcmVjZWl2ZQo+IHRoZSBsYXN0IG1lc3NhZ2Ug
Y29ycmVjdGx5IHdpdGggdGhlIGVuZC1vZi1tZXNzYWdlIGZsYWcgc2V0Lgo+IAo+IFRvIGF2b2lk
IHRoaXMgYWJvcnQgdGhlIHJlY2VwdGlvbiBvZiB0aGUgdHJhbnNhY3Rpb24gd2hlbiB0aGUgZmly
c3QKPiBlcnJvciBpcyBkZXRlY3RlZCwgcmVqZWN0aW5nIGFueSBtZXNzYWdlcyB1bnRpbCBhIG1l
c3NhZ2Ugd2l0aCB0aGUKPiBzdGFydC1vZi1tZXNzYWdlIGZsYWcgaXMgcmVjZWl2ZWQgKHdoaWNo
IHdpbGwgc3RhcnQgYSBuZXcKPiB0cmFuc2FjdGlvbikuCj4gVGhpcyBpcyBhbHNvIHdoYXQgdGhl
IERQIDEuNCBzcGVjIDIuMTEuOC4yIGNhbGxzIGZvciBpbiB0aGlzIGNhc2UuCj4gCj4gSW4gYWRk
dGlvbiB0aGlzIGFsc28gcHJldmVudHMgcmVjZWl2aW5nIGJvZ3VzIHRyYW5zYWN0aW9ucyB3aXRo
b3V0Cj4gdGhlCnMvYWRkdGlvbi9hZGRpdGlvbi8KCldpdGggdGhlIG9uZSBzbWFsbCBzcGVsbGlu
ZyBmaXg6CgpSZXZpZXdlZC1ieTogTHl1ZGUgPGx5dWRlQHJlZGhhdC5jb20+Cgo+IGZpcnN0IG1l
c3NhZ2Ugd2l0aCB0aGUgdGhlIHN0YXJ0LW9mLW1lc3NhZ2UgZmxhZyBzZXQuCj4gCj4gdjI6Cj4g
LSB1bmNoYW5nZWQKPiB2MzoKPiAtIGdpdCBhZGQgdGhlIHBhcnQgdGhhdCBhY3R1YWxseSBza2lw
cyBtZXNzYWdlcyBhZnRlciBhbiBlcnJvciBpbgo+ICAgZHJtX2RwX3NpZGViYW5kX21zZ19idWls
ZCgpCj4gCj4gQ2M6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gQ2M6IEx5dWRl
IDxseXVkZUByZWRoYXQuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm
d2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4K
PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYyB8IDMxICsrKysr
KysrKysrKysrKysrKysrKysrKy0KPiAtLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2Vy
dGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3Rv
cG9sb2d5LmMKPiBpbmRleCA3OGU5YTdkNTg3OTQuLjQxYjQ5MmY5OTk1NSAxMDA2NDQKPiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IEBAIC0zMzIsNiArMzMyLDEzIEBAIHN0YXRp
YyBib29sIGRybV9kcF9zaWRlYmFuZF9tc2dfYnVpbGQoc3RydWN0Cj4gZHJtX2RwX3NpZGViYW5k
X21zZ19yeCAqbXNnLAo+ICAJCQlyZXR1cm4gZmFsc2U7Cj4gIAkJfQo+ICAKPiArCQkvKgo+ICsJ
CSAqIGlnbm9yZSBvdXQtb2Ytb3JkZXIgbWVzc2FnZXMgb3IgbWVzc2FnZXMgdGhhdCBhcmUKPiBw
YXJ0IG9mIGEKPiArCQkgKiBmYWlsZWQgdHJhbnNhY3Rpb24KPiArCQkgKi8KPiArCQlpZiAoIXJl
Y3ZfaGRyLnNvbXQgJiYgIW1zZy0+aGF2ZV9zb210KQo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwo+
ICAJCS8qIGdldCBsZW5ndGggY29udGFpbmVkIGluIHRoaXMgcG9ydGlvbiAqLwo+ICAJCW1zZy0+
Y3VyY2h1bmtfbGVuID0gcmVjdl9oZHIubXNnX2xlbjsKPiAgCQltc2ctPmN1cmNodW5rX2hkcmxl
biA9IGhkcmxlbjsKPiBAQCAtMjE2OCw3ICsyMTc1LDcgQEAgaW50IGRybV9kcF9tc3RfdG9wb2xv
Z3lfbWdyX3Jlc3VtZShzdHJ1Y3QKPiBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyKQo+ICB9
Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2RwX21zdF90b3BvbG9neV9tZ3JfcmVzdW1lKTsKPiAgCj4g
LXN0YXRpYyB2b2lkIGRybV9kcF9nZXRfb25lX3NiX21zZyhzdHJ1Y3QgZHJtX2RwX21zdF90b3Bv
bG9neV9tZ3IKPiAqbWdyLCBib29sIHVwKQo+ICtzdGF0aWMgYm9vbCBkcm1fZHBfZ2V0X29uZV9z
Yl9tc2coc3RydWN0IGRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyCj4gKm1nciwgYm9vbCB1cCkKPiAg
ewo+ICAJaW50IGxlbjsKPiAgCXU4IHJlcGx5YmxvY2tbMzJdOwo+IEBAIC0yMTgzLDEyICsyMTkw
LDEyIEBAIHN0YXRpYyB2b2lkIGRybV9kcF9nZXRfb25lX3NiX21zZyhzdHJ1Y3QKPiBkcm1fZHBf
bXN0X3RvcG9sb2d5X21nciAqbWdyLCBib29sIHVwKQo+ICAJCQkgICAgICAgcmVwbHlibG9jaywg
bGVuKTsKPiAgCWlmIChyZXQgIT0gbGVuKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygiZmFpbGVkIHRv
IHJlYWQgRFBDRCBkb3duIHJlcCAlZAo+ICVkXG4iLCBsZW4sIHJldCk7Cj4gLQkJcmV0dXJuOwo+
ICsJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAgCXJldCA9IGRybV9kcF9zaWRlYmFuZF9tc2dfYnVp
bGQobXNnLCByZXBseWJsb2NrLCBsZW4sIHRydWUpOwo+ICAJaWYgKCFyZXQpIHsKPiAgCQlEUk1f
REVCVUdfS01TKCJzaWRlYmFuZCBtc2cgYnVpbGQgZmFpbGVkICVkXG4iLAo+IHJlcGx5YmxvY2tb
MF0pOwo+IC0JCXJldHVybjsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gIAl9Cj4gIAlyZXBseWxlbiA9
IG1zZy0+Y3VyY2h1bmtfbGVuICsgbXNnLT5jdXJjaHVua19oZHJsZW47Cj4gIAo+IEBAIC0yMjAy
LDI1ICsyMjA5LDMwIEBAIHN0YXRpYyB2b2lkIGRybV9kcF9nZXRfb25lX3NiX21zZyhzdHJ1Y3QK
PiBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyLCBib29sIHVwKQo+ICAJCWlmIChyZXQgIT0g
bGVuKSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byByZWFkIGEgY2h1bmsgKGxlbgo+
ICVkLCByZXQgJWQpXG4iLAo+ICAJCQkJICAgICAgbGVuLCByZXQpOwo+IC0JCQlyZXR1cm47Cj4g
KwkJCXJldHVybiBmYWxzZTsKPiAgCQl9Cj4gIAo+ICAJCXJldCA9IGRybV9kcF9zaWRlYmFuZF9t
c2dfYnVpbGQobXNnLCByZXBseWJsb2NrLAo+IGxlbiwgZmFsc2UpOwo+ICAJCWlmICghcmV0KSB7
Cj4gIAkJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBidWlsZCBzaWRlYmFuZAo+IG1zZ1xuIik7
Cj4gLQkJCXJldHVybjsKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICAJCX0KPiAgCj4gIAkJY3VycmVw
bHkgKz0gbGVuOwo+ICAJCXJlcGx5bGVuIC09IGxlbjsKPiAgCX0KPiArCXJldHVybiB0cnVlOwo+
ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGRybV9kcF9tc3RfaGFuZGxlX2Rvd25fcmVwKHN0cnVjdCBk
cm1fZHBfbXN0X3RvcG9sb2d5X21ncgo+ICptZ3IpCj4gIHsKPiAgCWludCByZXQgPSAwOwo+ICAK
PiAtCWRybV9kcF9nZXRfb25lX3NiX21zZyhtZ3IsIGZhbHNlKTsKPiArCWlmICghZHJtX2RwX2dl
dF9vbmVfc2JfbXNnKG1nciwgZmFsc2UpKSB7Cj4gKwkJbWVtc2V0KCZtZ3ItPmRvd25fcmVwX3Jl
Y3YsIDAsCj4gKwkJICAgICAgIHNpemVvZihzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ19yeCkp
Owo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICAKPiAgCWlmIChtZ3ItPmRvd25fcmVwX3JlY3YuaGF2
ZV9lb210KSB7Cj4gIAkJc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfdHggKnR4bXNnOwo+IEBA
IC0yMjc2LDcgKzIyODgsMTIgQEAgc3RhdGljIGludCBkcm1fZHBfbXN0X2hhbmRsZV9kb3duX3Jl
cChzdHJ1Y3QKPiBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyKQo+ICBzdGF0aWMgaW50IGRy
bV9kcF9tc3RfaGFuZGxlX3VwX3JlcShzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9tZ3IKPiAq
bWdyKQo+ICB7Cj4gIAlpbnQgcmV0ID0gMDsKPiAtCWRybV9kcF9nZXRfb25lX3NiX21zZyhtZ3Is
IHRydWUpOwo+ICsKPiArCWlmICghZHJtX2RwX2dldF9vbmVfc2JfbXNnKG1nciwgdHJ1ZSkpIHsK
PiArCQltZW1zZXQoJm1nci0+dXBfcmVxX3JlY3YsIDAsCj4gKwkJICAgICAgIHNpemVvZihzdHJ1
Y3QgZHJtX2RwX3NpZGViYW5kX21zZ19yeCkpOwo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICAKPiAg
CWlmIChtZ3ItPnVwX3JlcV9yZWN2LmhhdmVfZW9tdCkgewo+ICAJCXN0cnVjdCBkcm1fZHBfc2lk
ZWJhbmRfbXNnX3JlcV9ib2R5IG1zZzsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vZHJpLWRldmVsCg==