From: Jay Vosburgh <fubar@us.ibm.com>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: Veaceslav Falico <vfalico@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac
Date: Tue, 04 Feb 2014 12:00:31 -0800 [thread overview]
Message-ID: <15005.1391544031@death.nxdomain> (raw)
In-Reply-To: <52E3447B.6050206@huawei.com>
Ding Tianhong <dingtianhong@huawei.com> wrote:
>The parameter fail_over_mac only affect active-backup mode, if it was
>set to active or follow and works with other modes, just like RR or XOR
>mode, the bonding could not set all slaves to the master's address, it
>will cause the slave could not work well with master.
>
>v1->v2: According Jay's suggestion, that we should permit setting an option
> at any time, but only have it take effect in active-backup mode, so
> I add mode checking together with fail_over_mac during enslavement and
> rebuild the patches.
>
>v2->v3: The correct way to fix the problem is that we should not add restrictions when
> setting options, just need to modify the bond enslave and removal processing
> to check the mode in addition to fail_over_mac when setting a slave's MAC during
> enslavement. The change active slave processing already only calls the fail_over_mac
> function when in active-backup mode.
>
> Remove the cleanup patch because the net-next is frozen now.
>
>Regards
>Ding
Both patches look good to me.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2014-02-04 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 4:58 [PATCH RESEND net-next v3 0/2] bonding: Fix some issues for fail_over_mac Ding Tianhong
2014-02-02 0:53 ` David Miller
2014-02-04 20:00 ` Jay Vosburgh [this message]
2014-02-05 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15005.1391544031@death.nxdomain \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.