From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"osst@riede.org" <osst@riede.org>,
"sumit.saxena@broadcom.com" <sumit.saxena@broadcom.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"shivasharan.srikanteshwara@broadcom.com"
<shivasharan.srikanteshwara@broadcom.com>,
"kashyap.desai@broadcom.com" <kashyap.desai@broadcom.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SCSI: remove DRIVER_ATTR() usage
Date: Thu, 20 Jul 2017 02:20:02 +0000 [thread overview]
Message-ID: <1500517200.4629.0.camel@wdc.com> (raw)
In-Reply-To: <20170719125006.GA17776@kroah.com>
On Wed, 2017-07-19 at 14:50 +0200, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to
> explicitly show that this is a read/write or read/only sysfs file. So
> convert the remaining SCSI drivers that use the old style to use the
> newer macros.
>
> Bonus is that this removes some checkpatch.pl warnings :)
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2017-07-20 2:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 12:50 [PATCH] SCSI: remove DRIVER_ATTR() usage Greg KH
2017-07-20 2:20 ` Bart Van Assche [this message]
2017-07-25 1:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500517200.4629.0.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=osst@riede.org \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.