From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-acpi@vger.kernel.org
Cc: devicetree@vger.kernel.org, sudeep.holla@arm.com,
lorenzo.pieralisi@arm.com, mika.westerberg@linux.intel.com,
rafael@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
robh@kernel.org, ahs3@redhat.com, frowand.list@gmail.com,
erik.veijola@intel.com
Subject: Re: [PATCH v3 1/8] ACPI: Use IS_ERR_OR_NULL() instead of non-NULL check in is_acpi_data_node
Date: Fri, 21 Jul 2017 15:12:15 +0300 [thread overview]
Message-ID: <1500639135.29303.172.camel@linux.intel.com> (raw)
In-Reply-To: <1500638399.29303.166.camel@linux.intel.com>
On Fri, 2017-07-21 at 14:59 +0300, Andy Shevchenko wrote:
> On Fri, 2017-07-21 at 14:39 +0300, Sakari Ailus wrote:
> > The is_acpi_data_node() function takes a struct fwnode_handle
> > pointer
> > as
> > its argument. The validity of the pointer is first checked. Extend
> > the
> > check to cover error values as is done by similar is_acpi_node() and
> > is_acpi_device_node() functions.
> >
>
>
> It seems we will have three places with such code. Do we care to get
> rid
> of them in favor of is_acpi_data_node()? (I didn't read whole series
> yet, maybe it's already done)
Please, ignore this comment, I messed up with FWNODE_ACPI type.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-07-21 12:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 11:39 [PATCH v3 0/8] Remove fwnode type field, constify property fwnode arguments Sakari Ailus
2017-07-21 11:39 ` [PATCH v3 2/8] device property: Get rid of struct fwnode_handle type field Sakari Ailus
2017-07-21 11:39 ` [PATCH v3 3/8] ACPI: Prepare for constifying acpi_get_next_subnode() fwnode argument Sakari Ailus
2017-07-21 12:30 ` Andy Shevchenko
[not found] ` <1500637177-16095-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-21 11:39 ` [PATCH v3 1/8] ACPI: Use IS_ERR_OR_NULL() instead of non-NULL check in is_acpi_data_node Sakari Ailus
2017-07-21 11:59 ` Andy Shevchenko
2017-07-21 12:12 ` Andy Shevchenko [this message]
2017-07-21 11:39 ` [PATCH v3 4/8] ACPI: Constify acpi_bus helper functions, switch to macros Sakari Ailus
2017-07-21 11:52 ` [PATCH v3 0/8] Remove fwnode type field, constify property fwnode arguments Rafael J. Wysocki
2017-07-21 12:33 ` Andy Shevchenko
[not found] ` <1500640389.29303.177.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-21 12:29 ` Rafael J. Wysocki
2017-07-24 20:28 ` Rafael J. Wysocki
2017-08-08 9:32 ` Sakari Ailus
2017-08-09 0:53 ` Rafael J. Wysocki
2017-08-09 8:47 ` Sakari Ailus
2017-08-09 8:50 ` Sakari Ailus
2017-08-09 23:27 ` Rafael J. Wysocki
2017-07-21 11:39 ` [PATCH v3 5/8] ACPI: Constify internal " Sakari Ailus
2017-07-21 11:39 ` [PATCH v3 6/8] device property: Constify argument to pset fwnode backend Sakari Ailus
2017-07-21 11:39 ` [PATCH v3 7/8] device property: Constify fwnode property API Sakari Ailus
2017-07-21 11:39 ` [PATCH v3 8/8] device property: Introduce fwnode_property_get_reference_args Sakari Ailus
[not found] ` <1500637177-16095-9-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-21 12:06 ` Andy Shevchenko
2017-07-21 12:11 ` [PATCH v3.1 " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500639135.29303.172.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ahs3@redhat.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erik.veijola@intel.com \
--cc=frowand.list@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.